From: "Rainer Müller" <raimue@codingfarm.de>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: patches@linaro.org, Chad Joan <chadjoan@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses
Date: Sat, 3 Jun 2017 12:13:59 +0200 [thread overview]
Message-ID: <ed2675f7-08f7-5bcd-2ed3-3ecb865e54fe@codingfarm.de> (raw)
In-Reply-To: <1496414138-7622-1-git-send-email-peter.maydell@linaro.org>
On 2017-06-02 16:35, Peter Maydell wrote:
> diff --git a/configure b/configure
> index 0586ec9..6aca5d1 100755
> --- a/configure
> +++ b/configure
> @@ -3053,6 +3053,8 @@ int main(void) {
> EOF
> IFS=:
> for curses_inc in $curses_inc_list; do
> + # Make sure we get the wide character prototypes
> + curses_inc="-DNCURSES_WIDECHAR $curses_inc"
> IFS=:
> for curses_lib in $curses_lib_list; do
> unset IFS
>
Thank you for getting back to this. I can confirm that this patch fixes
--enable-curses for me on Mac OS X.
Although this already works as is, I would use -DNCURSES_WIDECHAR=1 as
ncurses.h uses #if and not #ifdef to check for this.
Rainer
next prev parent reply other threads:[~2017-06-03 10:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-02 14:35 [Qemu-devel] [PATCH] configure: Define NCURSES_WIDECHAR if we're using curses Peter Maydell
2017-06-02 21:58 ` Laszlo Ersek
2017-06-03 9:43 ` Kamil Rytarowski
2017-06-03 16:08 ` Laszlo Ersek
2017-06-03 10:13 ` Rainer Müller [this message]
2017-06-03 10:17 ` Kamil Rytarowski
2017-06-26 13:31 ` Peter Maydell
2021-06-06 18:13 ` Stefan Weil
2021-06-07 12:57 ` Laszlo Ersek
2021-06-07 13:05 ` Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2675f7-08f7-5bcd-2ed3-3ecb865e54fe@codingfarm.de \
--to=raimue@codingfarm.de \
--cc=chadjoan@gmail.com \
--cc=lersek@redhat.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).