From: "Michal Prívozník" <mprivozn@redhat.com>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
John Snow <jsnow@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
libvir-list@redhat.com
Subject: Re: [PATCH] qemu-options: Remove the deprecated -no-quit option
Date: Wed, 15 Dec 2021 10:07:53 +0100 [thread overview]
Message-ID: <ed2e415f-8f95-7ee8-b45a-0648706e7d01@redhat.com> (raw)
In-Reply-To: <20211215082417.180735-1-thuth@redhat.com>
On 12/15/21 09:24, Thomas Huth wrote:
> This option was just a wrapper around the -display ...,window-close=off
> parameter, and the name "no-quit" is rather confusing compared to
> "window-close" (since there are still other means to quit the emulator),
> so let's remove this now.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> docs/about/deprecated.rst | 6 ------
> docs/about/removed-features.rst | 7 +++++++
> qemu-options.hx | 8 --------
> softmmu/vl.c | 8 +-------
> 4 files changed, 8 insertions(+), 21 deletions(-)
Libvirt has never used it. So from my POV: ACK.
Michal
next prev parent reply other threads:[~2021-12-15 9:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-15 8:24 [PATCH] qemu-options: Remove the deprecated -no-quit option Thomas Huth
2021-12-15 9:07 ` Michal Prívozník [this message]
2021-12-15 9:11 ` Markus Armbruster
2021-12-15 9:24 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed2e415f-8f95-7ee8-b45a-0648706e7d01@redhat.com \
--to=mprivozn@redhat.com \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).