From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11C7AC4167B for ; Tue, 28 Nov 2023 17:39:10 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r822Y-0001Qu-Ir; Tue, 28 Nov 2023 12:38:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r822W-0001Ot-Hu; Tue, 28 Nov 2023 12:38:28 -0500 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r822T-0001gL-VK; Tue, 28 Nov 2023 12:38:28 -0500 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4SfqRw4D1Zz4wdF; Wed, 29 Nov 2023 04:38:20 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SfqRr5X0Qz4xPL; Wed, 29 Nov 2023 04:38:16 +1100 (AEDT) Message-ID: Date: Tue, 28 Nov 2023 18:38:10 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/3] pnv nest1 chiplet model Content-Language: en-US To: Chalapathi V , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, fbarrat@linux.ibm.com, npiggin@gmail.com, calebs@us.ibm.com, chalapathi.v@ibm.com, saif.abrar@linux.vnet.ibm.com References: <20231127171307.5237-1-chalapathi.v@linux.ibm.com> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20231127171307.5237-1-chalapathi.v@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=PHl3=HJ=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 11/27/23 18:13, Chalapathi V wrote: > Hello, > > Thank you for the review and suggestions on V5. > > The suggestions and changes requested from V5 are addressed in V6. > > Updates in Version 6 of this series are: > 1. adding a device-tree node in QEMU is removed as skiboot defines the > device-tree and QEMU should just follow it. > 2. Renamed PnvPerv to PnvNestChipletPervasive in PATCH1 as the model provides > the common pervasive registers of all nest chiplets. > 3. Nest1_chiplet model in PATCH2 is renamed to N1_chiplet to avoid the > confussions that may comeup later. > > Hence the new qom-tree looks like below. > (qemu) info qom-tree > /machine (powernv10-machine) > /chip[0] (power10_v2.0-pnv-chip) > /n1_chiplet (pnv-N1-chiplet) > /nest_pervasive_common (pnv-nest-chiplet-pervasive) > /xscom-n1_chiplet-control-regs[0] (memory-region) > /xscom-n1_chiplet-pb-scom-eq-regs[0] (memory-region) > /xscom-n1_chiplet-pb-scom-es-regs[0] (memory-region) > > Patches overview in V6. > PATCH1: Create a common nest pervasive chiplet model with control chiplet scom > registers. > PATCH2: Create a N1 chiplet model and implement powerbus scom registers. > Connect common nest pervasive model to N1 chiplet model to define > chiplet control scoms for N1 chiplet. > PATCH3: Connect N1 chiplet model to p10 chip. > > Test covered: > These changes are tested on a single socket and 2 socket P10 machine. It would be nice to add in tests/avocado/ppc_powernv.py a simple test case for a 2 socket machine : self.vm.add_args('-smp', '8,sockets=2,cores=1,threads=4') ... console_pattern = 'smp: Brought up 2 nodes, 8 CPUs' Thanks, C.