From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5378DE7B61F for ; Thu, 5 Oct 2023 06:55:55 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qoIGj-0007nB-Pb; Thu, 05 Oct 2023 02:55:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoIGi-0007lP-9V for qemu-devel@nongnu.org; Thu, 05 Oct 2023 02:55:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qoIGg-0004oP-Cl for qemu-devel@nongnu.org; Thu, 05 Oct 2023 02:55:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696488929; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Qhu7+UZGaEOQibJPCIBtZ2lujUlWrDW6Cl1mQhkeGmY=; b=YJnDjYkJHHbfeNaTY+VYkPELzwD7O+bhcOk2EHfyCEg0sRWICgDVRGc4Z6+vFKfb8C1sy4 jslWuyhJBQqWRJ38VBzumxyc/44OOOx3pV9ILNVtFi3RkCWPK9Sto3Eufz8IEvSGClvMqh arc++L/n+/qlZtG/HrIvnBLvaRrWHVo= Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-14--GFt-1OYMcOKdAkXu5qJsQ-1; Thu, 05 Oct 2023 02:55:22 -0400 X-MC-Unique: -GFt-1OYMcOKdAkXu5qJsQ-1 Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-77578227e4bso83357385a.2 for ; Wed, 04 Oct 2023 23:55:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696488922; x=1697093722; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:reply-to:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Qhu7+UZGaEOQibJPCIBtZ2lujUlWrDW6Cl1mQhkeGmY=; b=ce76cbityjezC5I/c8uhvyhnLqs3ZcBxuUuvyj59pfycNV+IeMZLpvsps07NtARVuN 1McAVU4keITJcXevIcYhFtfPWV5sTMWL71N7pQbE4upJE0hDaITCIABwIxQTAgwA7RnU I9ZARcd8NjCd/hsKqNTLH6Mcnt5S114KGp52BZWlehJjfVsrCbFykii8PfHC0nHFsCS3 TM/2VvnkScXp9wOidY62hDIghagjEkQWLCm3ppD7anGRIXPWWb0FpNMFd00Jwrg5REZA 4DXtaZx9GezxkDyx56caiEpAwOsc/nywqGYd87+c3oTW7eNYdfNJZWuMt3CM3XvGMhRn SbCQ== X-Gm-Message-State: AOJu0YxWI97Kt1JXrtAPymjvAx5xwZ03XTx/IRf0DbLxaheFBJUg56lO S+uQt39EgpSte4vYPG9PxHS/7lxbKwkqIIGRcKQXZ1sYa09wjoJrkNQKfOOhbyxearaK1imyi/8 ZzWcUSUebRtDrTXQ= X-Received: by 2002:a05:620a:234:b0:774:15ad:f34c with SMTP id u20-20020a05620a023400b0077415adf34cmr4132497qkm.70.1696488922258; Wed, 04 Oct 2023 23:55:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCau9U3B/IJ3t3bO6dotJ+oNBNm1OQT4ekCgdC2y1V63zpo/wxl8s4+MK8ZPbH5Rnr7KJP9g== X-Received: by 2002:a05:620a:234:b0:774:15ad:f34c with SMTP id u20-20020a05620a023400b0077415adf34cmr4132476qkm.70.1696488921907; Wed, 04 Oct 2023 23:55:21 -0700 (PDT) Received: from ?IPV6:2a01:e0a:59e:9d80:527b:9dff:feef:3874? ([2a01:e0a:59e:9d80:527b:9dff:feef:3874]) by smtp.gmail.com with ESMTPSA id s8-20020ae9f708000000b0077411a459a8sm286785qkg.4.2023.10.04.23.55.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Oct 2023 23:55:21 -0700 (PDT) Message-ID: Date: Thu, 5 Oct 2023 08:55:16 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v4 00/15] Prerequisite changes for IOMMUFD support Content-Language: en-US To: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= , eric.auger.pro@gmail.com, qemu-devel@nongnu.org, zhenzhong.duan@intel.com, alex.williamson@redhat.com, jgg@nvidia.com, nicolinc@nvidia.com, joao.m.martins@oracle.com, peterx@redhat.com, kevin.tian@intel.com, yi.l.liu@intel.com, yi.y.sun@intel.com, chao.p.peng@intel.com, mjrosato@linux.ibm.com, aik@ozlabs.ru References: <20231004154518.334760-1-eric.auger@redhat.com> <81ead96c-e7e7-2d38-db77-264d7aee924a@redhat.com> From: Eric Auger In-Reply-To: <81ead96c-e7e7-2d38-db77-264d7aee924a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.133.124; envelope-from=eric.auger@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.528, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: eric.auger@redhat.com Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Hi Cédric, On 10/4/23 21:58, Cédric Le Goater wrote: > On 10/4/23 17:43, Eric Auger wrote: >> Hi All, >> >> With the agreement of Zhenzhong, here is a v3 respin of the IOMMUFD >> prerequisite series. This applies on top of vfio-next: >> https://github.com/legoater/qemu/, branch vfio-next. >> >> Per Cédric's suggestion, the IOMMUFD patchset v1[1] is now split >> into two series, this prerequisite series and the new IOMMUFD backend >> introduction support series. Hopefully this will ease the review. >> >> The main purpose of this series is to make "common.c" group agnostic: >> all group related code are moved into container.c. Then we are prepared >> for next series, abstract base container, adding new backend, etc. >> >> This series can be found at >> https://github.com/eauger/qemu/tree/prereq_v4 >> >> Test done: >> - PCI device were tested >> - device hotplug test >> - with or without vIOMMU >> - VFIO migration with a E800 net card(no dirty sync support) passthrough >> - platform and ccw were only compile-tested due to environment limit >> >> Zhenzhong, Yi, Eric > > LGTM, I did a small adjustment in vfio_detach_device() in patches 13+15. > > Applied to vfio-next. Thanks! Eric > > Thanks, > > C. > > >> [1] >> https://lore.kernel.org/all/20230830103754.36461-1-zhenzhong.duan@intel.com/t/#u >> >> Changelog: >> >> v4: >> - include qemu/error-report.h in helpers.c >> - in ap.c, fix the wrongly added >>    vfio_detach_device(vbasedev) and g_free(vbasedev->name); >>    also added error_prepend >> - simplified vbasedev setting in ccw.c >> - vfio_detach_device: dropped check on >>    !vbasedev->container >> - container.c: restore dropped comment >> >> v3: >> - rebased on vfio-next as suggested by Cedric >> - added vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any >> - collected Cedric's R-b >> - Fix some error paths in vfio/cpi which now properly detach the device >>    and also free the vbasedev->name >> - Fix vfio/ccw migration (hopefully) [Matthew inputs] >> - Split [PATCH v2 11/12] vfio/common: Introduce two kinds of VFIO >> device lists >>    into 3 patches >> >> v2: >> - Refine patch description per Eric >> - return errno and errp in vfio_kvm_device_[add/del]_fd per Eric >> - make memory listener register/deregister in seperate patch per Eric >> - Include the .h file first per Cédric >> - Add trace event in vfio_attach_device per Cédric >> - drop the change to vfio_viommu_preset by refactor per Cédric >> - Introduce global VFIO device list and per container list per Alex >> >> Note changelog below are from full IOMMUFD series: >> >> v1: >> - Alloc hwpt instead of using auto hwpt >> - elaborate iommufd code per Nicolin >> - consolidate two patches and drop as.c >> - typo error fix and function rename >> >> rfcv4: >> - rebase on top of v8.0.3 >> - Add one patch from Yi which is about vfio device add in kvm >> - Remove IOAS_COPY optimization and focus on functions in this patchset >> - Fix wrong name issue reported and fix suggested by Matthew >> - Fix compilation issue reported and fix sugggsted by Nicolin >> - Use query_dirty_bitmap callback to replace get_dirty_bitmap for better >> granularity >> - Add dev_iter_next() callback to avoid adding so many callback >>    at container scope, add VFIODevice.hwpt to support that >> - Restore all functions back to common from container whenever possible, >>    mainly migration and reset related functions >> - Add --enable/disable-iommufd config option, enabled by default in >> linux >> - Remove VFIODevice.hwpt_next as it's redundant with VFIODevice.next >> - Adapt new VFIO_DEVICE_PCI_HOT_RESET uAPI for IOMMUFD backed device >> - vfio_kvm_device_add/del_group call vfio_kvm_device_add/del_fd to >> remove >> redundant code >> - Add FD passing support for vfio device backed by IOMMUFD >> - Fix hot unplug resource leak issue in vfio_legacy_detach_device() >> - Fix FD leak in vfio_get_devicefd() >> >> rfcv3: >> - rebase on top of v7.2.0 >> - Fix the compilation with CONFIG_IOMMUFD unset by using true classes >> for >>    VFIO backends >> - Fix use after free in error path, reported by Alister >> - Split common.c in several steps to ease the review >> >> rfcv2: >> - remove the first three patches of rfcv1 >> - add open cdev helper suggested by Jason >> - remove the QOMification of the VFIOContainer and simply use >> standard ops >> (David) >> - add "-object iommufd" suggested by Alex >> >> Thanks >> Zhenzhong >> >> >> Eric Auger (7): >>    scripts/update-linux-headers: Add iommufd.h >>    vfio/common: Propagate KVM_SET_DEVICE_ATTR error if any >>    vfio/common: Introduce vfio_container_add|del_section_window() >>    vfio/pci: Introduce vfio_[attach/detach]_device >>    vfio/platform: Use vfio_[attach/detach]_device >>    vfio/ap: Use vfio_[attach/detach]_device >>    vfio/ccw: Use vfio_[attach/detach]_device >> >> Yi Liu (2): >>    vfio/common: Move IOMMU agnostic helpers to a separate file >>    vfio/common: Move legacy VFIO backend code into separate container.c >> >> Zhenzhong Duan (6): >>    linux-headers: Add iommufd.h >>    vfio/common: Extract out vfio_kvm_device_[add/del]_fd >>    vfio/common: Move VFIO reset handler registration to a group agnostic >>      function >>    vfio/common: Introduce a per container device list >>    vfio/common: Store the parent container in VFIODevice >>    vfio/common: Introduce a global VFIODevice list >> >>   include/hw/vfio/vfio-common.h   |   60 +- >>   linux-headers/linux/iommufd.h   |  444 ++++++++ >>   hw/vfio/ap.c                    |   69 +- >>   hw/vfio/ccw.c                   |  122 +- >>   hw/vfio/common.c                | 1851 ++----------------------------- >>   hw/vfio/container.c             | 1157 +++++++++++++++++++ >>   hw/vfio/helpers.c               |  612 ++++++++++ >>   hw/vfio/pci.c                   |   67 +- >>   hw/vfio/platform.c              |   43 +- >>   hw/vfio/meson.build             |    2 + >>   hw/vfio/trace-events            |    4 +- >>   scripts/update-linux-headers.sh |    3 +- >>   12 files changed, 2458 insertions(+), 1976 deletions(-) >>   create mode 100644 linux-headers/linux/iommufd.h >>   create mode 100644 hw/vfio/container.c >>   create mode 100644 hw/vfio/helpers.c >> >