From: "Leonardo Brás" <leobras@redhat.com>
To: "Cédric Le Goater" <clg@kaod.org>,
quintela@redhat.com,
"David Edmondson" <david.edmondson@oracle.com>
Cc: qemu-devel@nongnu.org, Peter Xu <peterx@redhat.com>,
Greg Kurz <groug@kaod.org>,
qemu-s390x@nongnu.org, Fam Zheng <fam@euphon.net>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Halil Pasic <pasic@linux.ibm.com>, John Snow <jsnow@redhat.com>,
qemu-ppc@nongnu.org,
Daniel Henrique Barboza <danielhb413@gmail.com>,
Harsh Prateek Bora <harshpb@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Richard Henderson <richard.henderson@linaro.org>,
David Gibson <david@gibson.dropbear.id.au>,
David Hildenbrand <david@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eric Farman <farman@linux.ibm.com>,
qemu-block@nongnu.org, Eric Blake <eblake@redhat.com>,
Thomas Huth <thuth@redhat.com>,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Subject: Re: [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate
Date: Mon, 22 May 2023 22:57:33 -0300 [thread overview]
Message-ID: <ed4955433ff488a4e9c08f50e0a4a9813ba0665f.camel@redhat.com> (raw)
In-Reply-To: <ee1979b4-1a64-607d-8fbd-4bfd9c5b317b@kaod.org>
On Tue, 2023-05-16 at 14:47 +0200, Cédric Le Goater wrote:
> On 5/16/23 11:24, Juan Quintela wrote:
> > David Edmondson <david.edmondson@oracle.com> wrote:
> > > Juan Quintela <quintela@redhat.com> writes:
> > >
> > > > Define and use RATE_LIMIT_MAX instead.
> > >
> > > Suggest "RATE_LIMIT_MAX_NONE".
> >
> > Then even better
> >
> > RATE_LIMIT_DISABLED?
>
> I'd vote for RATE_LIMIT_DISABLED.
Me too.
>
> > RATE_LIMIT_NONE?
> >
> > Using MAX and NONE at the same time looks strange.
>
> Cheers,
>
> C.
>
Reviewed-by: Leonardo Bras <leobras@redhat.com>
next prev parent reply other threads:[~2023-05-23 1:58 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 19:56 [PATCH v2 00/16] Migration: More migration atomic counters Juan Quintela
2023-05-15 19:56 ` [PATCH v2 01/16] migration: Don't use INT64_MAX for unlimited rate Juan Quintela
2023-05-16 4:49 ` Harsh Prateek Bora
2023-05-16 9:13 ` David Edmondson
2023-05-16 9:24 ` Juan Quintela
2023-05-16 9:55 ` David Edmondson
2023-05-16 12:47 ` Cédric Le Goater
2023-05-23 1:57 ` Leonardo Brás [this message]
2023-05-15 19:56 ` [PATCH v2 02/16] migration: Correct transferred bytes value Juan Quintela
2023-05-16 9:35 ` David Edmondson
2023-05-23 2:15 ` Leonardo Brás
2023-05-26 8:04 ` Juan Quintela
2023-05-26 18:50 ` Leonardo Bras Soares Passos
2023-05-30 10:30 ` Juan Quintela
2023-05-15 19:56 ` [PATCH v2 03/16] migration: Move setup_time to mig_stats Juan Quintela
2023-05-16 9:42 ` David Edmondson
2023-05-16 10:06 ` Juan Quintela
2023-05-16 11:07 ` David Edmondson
2023-05-25 1:18 ` Leonardo Brás
2023-05-26 8:07 ` Juan Quintela
2023-05-26 18:53 ` Leonardo Bras Soares Passos
2023-05-15 19:56 ` [PATCH v2 04/16] qemu-file: Account for rate_limit usage on qemu_fflush() Juan Quintela
2023-05-25 1:33 ` Leonardo Brás
2023-05-26 8:09 ` Juan Quintela
2023-05-26 18:54 ` Leonardo Bras Soares Passos
2023-05-15 19:56 ` [PATCH v2 05/16] migration: Move rate_limit_max and rate_limit_used to migration_stats Juan Quintela
2023-05-16 12:43 ` Cédric Le Goater
2023-05-25 3:06 ` Leonardo Brás
2023-05-15 19:56 ` [PATCH v2 06/16] migration: Move migration_total_bytes() to migration-stats.c Juan Quintela
2023-05-25 3:09 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 07/16] migration: Add a trace for migration_transferred_bytes Juan Quintela
2023-05-25 3:18 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 08/16] migration: Use migration_transferred_bytes() to calculate rate_limit Juan Quintela
2023-05-25 6:50 ` Leonardo Brás
2023-05-26 8:17 ` Juan Quintela
2023-05-26 18:59 ` Leonardo Bras Soares Passos
2023-05-15 19:57 ` [PATCH v2 09/16] migration: We don't need the field rate_limit_used anymore Juan Quintela
2023-05-25 6:50 ` Leonardo Brás
2023-05-26 8:18 ` Juan Quintela
2023-05-26 18:59 ` Leonardo Bras Soares Passos
2023-05-15 19:57 ` [PATCH v2 10/16] migration: Don't abuse qemu_file transferred for RDMA Juan Quintela
2023-05-25 6:53 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 11/16] migration/RDMA: It is accounting for zero/normal pages in two places Juan Quintela
2023-05-25 7:06 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 12/16] migration/rdma: Remove QEMUFile parameter when not used Juan Quintela
2023-05-25 7:21 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 13/16] migration/rdma: Don't use imaginary transfers Juan Quintela
2023-05-25 7:27 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 14/16] migration: Remove unused qemu_file_credit_transfer() Juan Quintela
2023-05-25 7:29 ` Leonardo Brás
2023-05-15 19:57 ` [PATCH v2 15/16] migration/rdma: Simplify the function that saves a page Juan Quintela
2023-05-25 8:10 ` Leonardo Brás
2023-05-26 8:21 ` Juan Quintela
2023-05-26 19:03 ` Leonardo Bras Soares Passos
2023-05-15 19:57 ` [PATCH v2 16/16] migration/multifd: Compute transferred bytes correctly Juan Quintela
2023-05-25 8:38 ` Leonardo Brás
2023-05-26 8:23 ` Juan Quintela
2023-05-26 19:04 ` Leonardo Bras Soares Passos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed4955433ff488a4e9c08f50e0a4a9813ba0665f.camel@redhat.com \
--to=leobras@redhat.com \
--cc=borntraeger@linux.ibm.com \
--cc=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david.edmondson@oracle.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=farman@linux.ibm.com \
--cc=groug@kaod.org \
--cc=harshpb@linux.ibm.com \
--cc=iii@linux.ibm.com \
--cc=jsnow@redhat.com \
--cc=pasic@linux.ibm.com \
--cc=peterx@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=quintela@redhat.com \
--cc=richard.henderson@linaro.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).