From: John Snow <jsnow@redhat.com>
To: Bin Meng <bmeng.cn@gmail.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Wainer dos Santos Moschetta <wainersm@redhat.com>,
Cleber Rosa <crosa@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 1/3] python: add mypy config
Date: Tue, 13 Oct 2020 13:00:00 -0400 [thread overview]
Message-ID: <ed658177-4310-e2ba-2670-b37f0d337829@redhat.com> (raw)
In-Reply-To: <CAEUhbmWJ62viai9C7_zfx-do7DW0Mh_xjT7G8a8p+mdi9tCfkw@mail.gmail.com>
On 10/13/20 5:15 AM, Bin Meng wrote:
> On Sat, Oct 10, 2020 at 1:54 AM John Snow <jsnow@redhat.com> wrote:
>>
>> Formalize the options used for checking the python library. You can run
>> mypy from the directory that mypy.ini is in by typing `mypy qemu/`.
>>
>> Signed-off-by: John Snow <jsnow@redhat.com>
>> ---
>> python/mypy.ini | 4 ++++
>> 1 file changed, 4 insertions(+)
>> create mode 100644 python/mypy.ini
>>
>> diff --git a/python/mypy.ini b/python/mypy.ini
>> new file mode 100644
>> index 00000000000..7a70eca47c6
>> --- /dev/null
>> +++ b/python/mypy.ini
>> @@ -0,0 +1,4 @@
>> +[mypy]
>> +strict = True
>> +python_version = 3.6
>> +warn_unused_configs = True
>> \ No newline at end of file
>
> Missing "\n" at the end of file
>
> Regards,
> Bin
>
Easily fixed, thanks!
next prev parent reply other threads:[~2020-10-13 17:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-09 17:51 [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3 John Snow
2020-10-09 17:51 ` [PATCH 1/3] python: add mypy config John Snow
2020-10-13 9:15 ` Bin Meng
2020-10-13 17:00 ` John Snow [this message]
2020-10-09 17:51 ` [PATCH 2/3] python/qemu/qmp.py: re-raise OSError when encountered John Snow
2020-10-09 19:34 ` Philippe Mathieu-Daudé
2020-10-09 17:51 ` [PATCH 3/3] python/qemu/qmp.py: Fix settimeout operation John Snow
2020-10-09 19:35 ` Philippe Mathieu-Daudé
2020-10-09 17:52 ` [PATCH 0/3] python/qemu: strictly typed mypy conversion, pt3 John Snow
2020-10-12 14:54 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed658177-4310-e2ba-2670-b37f0d337829@redhat.com \
--to=jsnow@redhat.com \
--cc=bmeng.cn@gmail.com \
--cc=crosa@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).