From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, qemu-ppc@nongnu.org,
qemu-s390x@nongnu.org, qemu-arm@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [PATCH 4/6] hw/loader: Pass ELFDATA endian order argument to load_elf_ram_sym()
Date: Mon, 27 Jan 2025 13:22:35 -0800 [thread overview]
Message-ID: <ed920ff2-2bf6-41d6-b67b-89aa34c4ea2c@linaro.org> (raw)
In-Reply-To: <20250127113824.50177-5-philmd@linaro.org>
On 1/27/25 03:38, Philippe Mathieu-Daudé wrote:
> Rather than passing a boolean 'is_big_endian' argument,
> directly pass the ELFDATA, which can be unspecified using
> the ELFDATANONE value.
>
> Update the call sites:
> 0 -> ELFDATA2LSB
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> include/hw/loader.h | 4 ++--
> hw/core/loader.c | 23 ++++++++++-------------
> hw/riscv/boot.c | 3 ++-
> 3 files changed, 14 insertions(+), 16 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2025-01-27 21:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 11:38 [PATCH 0/6] hw/loader: Pass ELFDATA endian order argument to load_elf() Philippe Mathieu-Daudé
2025-01-27 11:38 ` [PATCH 1/6] hw/avr/boot: Replace load_elf_ram_sym() -> load_elf_as() Philippe Mathieu-Daudé
2025-01-27 21:11 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 2/6] hw/loader: Remove unused load_elf_ram() Philippe Mathieu-Daudé
2025-01-27 21:12 ` Richard Henderson
2025-01-28 2:14 ` Alistair Francis
2025-01-27 11:38 ` [PATCH 3/6] hw/loader: Clarify local variable name in load_elf_ram_sym() Philippe Mathieu-Daudé
2025-01-27 13:00 ` BALATON Zoltan
2025-01-27 21:13 ` Richard Henderson
2025-01-27 21:16 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 4/6] hw/loader: Pass ELFDATA endian order argument to load_elf_ram_sym() Philippe Mathieu-Daudé
2025-01-27 21:22 ` Richard Henderson [this message]
2025-01-27 11:38 ` [PATCH 5/6] hw/loader: Pass ELFDATA endian order argument to load_elf_as() Philippe Mathieu-Daudé
2025-01-27 21:26 ` Richard Henderson
2025-01-27 11:38 ` [PATCH 6/6] hw/loader: Pass ELFDATA endian order argument to load_elf() Philippe Mathieu-Daudé
2025-01-27 13:23 ` BALATON Zoltan
2025-01-27 21:34 ` Richard Henderson
2025-01-30 21:40 ` [PATCH 0/6] " Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ed920ff2-2bf6-41d6-b67b-89aa34c4ea2c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).