From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95455E75450 for ; Tue, 3 Oct 2023 11:44:12 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qndo9-0004Ea-1C; Tue, 03 Oct 2023 07:43:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qndo6-0004Dm-Lo; Tue, 03 Oct 2023 07:43:18 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qndo4-0005nT-4b; Tue, 03 Oct 2023 07:43:18 -0400 Received: from lhrpeml100006.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S0GB81s8xz6K6Ds; Tue, 3 Oct 2023 19:41:36 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (7.191.163.213) by lhrpeml100006.china.huawei.com (7.191.160.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 3 Oct 2023 12:43:11 +0100 Received: from lhrpeml500001.china.huawei.com ([7.191.163.213]) by lhrpeml500001.china.huawei.com ([7.191.163.213]) with mapi id 15.01.2507.031; Tue, 3 Oct 2023 12:43:11 +0100 To: Jonathan Cameron CC: "qemu-devel@nongnu.org" , "qemu-arm@nongnu.org" , "maz@kernel.org" , "jean-philippe@linaro.org" , "lpieralisi@kernel.org" , "peter.maydell@linaro.org" , "richard.henderson@linaro.org" , "imammedo@redhat.com" , "andrew.jones@linux.dev" , "david@redhat.com" , "philmd@linaro.org" , "eric.auger@redhat.com" , "oliver.upton@linux.dev" , "pbonzini@redhat.com" , "mst@redhat.com" , "will@kernel.org" , "gshan@redhat.com" , "rafael@kernel.org" , "alex.bennee@linaro.org" , "linux@armlinux.org.uk" , "darren@os.amperecomputing.com" , "ilkka@os.amperecomputing.com" , "vishnu@os.amperecomputing.com" , "karl.heubaum@oracle.com" , "miguel.luis@oracle.com" , "salil.mehta@opnsrc.net" , zhukeqian , "wangxiongfeng (C)" , "wangyanan (Y)" , "jiakernel2@gmail.com" , "maobibo@loongson.cn" , "lixianglai@loongson.cn" , Linuxarm Subject: RE: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan Thread-Topic: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan Thread-Index: AQHZ8zQk6MAP2ANe7ES6Fefhb3Wj6LA2n9eAgAFUrJA= Date: Tue, 3 Oct 2023 11:43:11 +0000 Message-ID: References: <20230930001933.2660-1-salil.mehta@huawei.com> <20230930001933.2660-7-salil.mehta@huawei.com> <20231002171423.00003c39@Huawei.com> In-Reply-To: <20231002171423.00003c39@Huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.168.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Salil Mehta From: Salil Mehta via Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org > From: Jonathan Cameron > Sent: Monday, October 2, 2023 5:14 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; maz@kernel.org; jean- > philippe@linaro.org; lpieralisi@kernel.org; peter.maydell@linaro.org; > richard.henderson@linaro.org; imammedo@redhat.com; andrew.jones@linux.dev= ; > david@redhat.com; philmd@linaro.org; eric.auger@redhat.com; > oliver.upton@linux.dev; pbonzini@redhat.com; mst@redhat.com; > will@kernel.org; gshan@redhat.com; rafael@kernel.org; > alex.bennee@linaro.org; linux@armlinux.org.uk; > darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; > vishnu@os.amperecomputing.com; karl.heubaum@oracle.com; > miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian > ; wangxiongfeng (C) ; > wangyanan (Y) ; jiakernel2@gmail.com; > maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm > Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cp= u > scan >=20 > On Sat, 30 Sep 2023 01:19:29 +0100 > Salil Mehta wrote: >=20 > > OSPM evaluates _EVT method to map the event. The cpu hotplug event even= tually > > results in start of the cpu scan. Scan figures out the cpu and the kind= of > > event(plug/unplug) and notifies it back to the guest. > > > > The change in this patch updates the GED AML _EVT method with the call = to > > \\_SB.CPUS.CSCN which will do above. > > > > Co-developed-by: Keqian Zhu > > Signed-off-by: Keqian Zhu > > Signed-off-by: Salil Mehta > One trivial suggested addition inline (dropping existing definition that = this > replicates). With that tidied up >=20 > Reviewed-by: Jonathan Cameron Thanks Salil. >=20 > > --- > > hw/acpi/generic_event_device.c | 4 ++++ > > include/hw/acpi/cpu_hotplug.h | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/hw/acpi/generic_event_device.c > b/hw/acpi/generic_event_device.c > > index d2fa1d0e4a..62d504d231 100644 > > --- a/hw/acpi/generic_event_device.c > > +++ b/hw/acpi/generic_event_device.c > > @@ -108,6 +108,10 @@ void build_ged_aml(Aml *table, const char *name, > HotplugHandler *hotplug_dev, > > aml_append(if_ctx, aml_call0(MEMORY_DEVICES_CONTAINER > "." > > MEMORY_SLOT_SCAN_METHOD))= ; > > break; > > + case ACPI_GED_CPU_HOTPLUG_EVT: > > + aml_append(if_ctx, aml_call0(ACPI_CPU_CONTAINER "." > > + ACPI_CPU_SCAN_METHOD)); > > + break; > > case ACPI_GED_PWR_DOWN_EVT: > > aml_append(if_ctx, > > > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), > > diff --git a/include/hw/acpi/cpu_hotplug.h > b/include/hw/acpi/cpu_hotplug.h > > index 48b291e45e..ef631750b4 100644 > > --- a/include/hw/acpi/cpu_hotplug.h > > +++ b/include/hw/acpi/cpu_hotplug.h > > @@ -20,6 +20,8 @@ > > #include "hw/acpi/cpu.h" > > > > #define ACPI_CPU_HOTPLUG_REG_LEN 12 > > +#define ACPI_CPU_SCAN_METHOD "CSCN" >=20 > This seems to already be defined in hw/acpi/cpu.c > Can we drop it from there given that file now includes this > header anyway. Perhaps I can assign this to the macro in the hw/acpi/cpu.c? Thanks Salil. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1qndo8-0004EL-IV for mharc-qemu-devel@gnu.org; Tue, 03 Oct 2023 07:43:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qndo6-0004Dm-Lo; Tue, 03 Oct 2023 07:43:18 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qndo4-0005nT-4b; Tue, 03 Oct 2023 07:43:18 -0400 Received: from lhrpeml100006.china.huawei.com (unknown [172.18.147.200]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4S0GB81s8xz6K6Ds; Tue, 3 Oct 2023 19:41:36 +0800 (CST) Received: from lhrpeml500001.china.huawei.com (7.191.163.213) by lhrpeml100006.china.huawei.com (7.191.160.224) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.31; Tue, 3 Oct 2023 12:43:11 +0100 Received: from lhrpeml500001.china.huawei.com ([7.191.163.213]) by lhrpeml500001.china.huawei.com ([7.191.163.213]) with mapi id 15.01.2507.031; Tue, 3 Oct 2023 12:43:11 +0100 From: Salil Mehta To: Jonathan Cameron CC: "qemu-devel@nongnu.org" , "qemu-arm@nongnu.org" , "maz@kernel.org" , "jean-philippe@linaro.org" , "lpieralisi@kernel.org" , "peter.maydell@linaro.org" , "richard.henderson@linaro.org" , "imammedo@redhat.com" , "andrew.jones@linux.dev" , "david@redhat.com" , "philmd@linaro.org" , "eric.auger@redhat.com" , "oliver.upton@linux.dev" , "pbonzini@redhat.com" , "mst@redhat.com" , "will@kernel.org" , "gshan@redhat.com" , "rafael@kernel.org" , "alex.bennee@linaro.org" , "linux@armlinux.org.uk" , "darren@os.amperecomputing.com" , "ilkka@os.amperecomputing.com" , "vishnu@os.amperecomputing.com" , "karl.heubaum@oracle.com" , "miguel.luis@oracle.com" , "salil.mehta@opnsrc.net" , zhukeqian , "wangxiongfeng (C)" , "wangyanan (Y)" , "jiakernel2@gmail.com" , "maobibo@loongson.cn" , "lixianglai@loongson.cn" , Linuxarm Subject: RE: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan Thread-Topic: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cpu scan Thread-Index: AQHZ8zQk6MAP2ANe7ES6Fefhb3Wj6LA2n9eAgAFUrJA= Date: Tue, 3 Oct 2023 11:43:11 +0000 Message-ID: References: <20230930001933.2660-1-salil.mehta@huawei.com> <20230930001933.2660-7-salil.mehta@huawei.com> <20231002171423.00003c39@Huawei.com> In-Reply-To: <20231002171423.00003c39@Huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.126.168.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-CFilter-Loop: Reflected Received-SPF: pass client-ip=185.176.79.56; envelope-from=salil.mehta@huawei.com; helo=frasgout.his.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Oct 2023 11:43:19 -0000 Message-ID: <20231003114311.i5OTsZ_NmCUZcRmR2k6JbI4sHIvIwpzcozsmn4oN_vI@z> > From: Jonathan Cameron > Sent: Monday, October 2, 2023 5:14 PM > To: Salil Mehta > Cc: qemu-devel@nongnu.org; qemu-arm@nongnu.org; maz@kernel.org; jean- > philippe@linaro.org; lpieralisi@kernel.org; peter.maydell@linaro.org; > richard.henderson@linaro.org; imammedo@redhat.com; andrew.jones@linux.dev= ; > david@redhat.com; philmd@linaro.org; eric.auger@redhat.com; > oliver.upton@linux.dev; pbonzini@redhat.com; mst@redhat.com; > will@kernel.org; gshan@redhat.com; rafael@kernel.org; > alex.bennee@linaro.org; linux@armlinux.org.uk; > darren@os.amperecomputing.com; ilkka@os.amperecomputing.com; > vishnu@os.amperecomputing.com; karl.heubaum@oracle.com; > miguel.luis@oracle.com; salil.mehta@opnsrc.net; zhukeqian > ; wangxiongfeng (C) ; > wangyanan (Y) ; jiakernel2@gmail.com; > maobibo@loongson.cn; lixianglai@loongson.cn; Linuxarm > Subject: Re: [PATCH V2 06/10] hw/acpi: Update GED _EVT method AML with cp= u > scan >=20 > On Sat, 30 Sep 2023 01:19:29 +0100 > Salil Mehta wrote: >=20 > > OSPM evaluates _EVT method to map the event. The cpu hotplug event even= tually > > results in start of the cpu scan. Scan figures out the cpu and the kind= of > > event(plug/unplug) and notifies it back to the guest. > > > > The change in this patch updates the GED AML _EVT method with the call = to > > \\_SB.CPUS.CSCN which will do above. > > > > Co-developed-by: Keqian Zhu > > Signed-off-by: Keqian Zhu > > Signed-off-by: Salil Mehta > One trivial suggested addition inline (dropping existing definition that = this > replicates). With that tidied up >=20 > Reviewed-by: Jonathan Cameron Thanks Salil. >=20 > > --- > > hw/acpi/generic_event_device.c | 4 ++++ > > include/hw/acpi/cpu_hotplug.h | 2 ++ > > 2 files changed, 6 insertions(+) > > > > diff --git a/hw/acpi/generic_event_device.c > b/hw/acpi/generic_event_device.c > > index d2fa1d0e4a..62d504d231 100644 > > --- a/hw/acpi/generic_event_device.c > > +++ b/hw/acpi/generic_event_device.c > > @@ -108,6 +108,10 @@ void build_ged_aml(Aml *table, const char *name, > HotplugHandler *hotplug_dev, > > aml_append(if_ctx, aml_call0(MEMORY_DEVICES_CONTAINER > "." > > MEMORY_SLOT_SCAN_METHOD))= ; > > break; > > + case ACPI_GED_CPU_HOTPLUG_EVT: > > + aml_append(if_ctx, aml_call0(ACPI_CPU_CONTAINER "." > > + ACPI_CPU_SCAN_METHOD)); > > + break; > > case ACPI_GED_PWR_DOWN_EVT: > > aml_append(if_ctx, > > > aml_notify(aml_name(ACPI_POWER_BUTTON_DEVICE), > > diff --git a/include/hw/acpi/cpu_hotplug.h > b/include/hw/acpi/cpu_hotplug.h > > index 48b291e45e..ef631750b4 100644 > > --- a/include/hw/acpi/cpu_hotplug.h > > +++ b/include/hw/acpi/cpu_hotplug.h > > @@ -20,6 +20,8 @@ > > #include "hw/acpi/cpu.h" > > > > #define ACPI_CPU_HOTPLUG_REG_LEN 12 > > +#define ACPI_CPU_SCAN_METHOD "CSCN" >=20 > This seems to already be defined in hw/acpi/cpu.c > Can we drop it from there given that file now includes this > header anyway. Perhaps I can assign this to the macro in the hw/acpi/cpu.c? Thanks Salil.