From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE96AC2D0A3 for ; Fri, 6 Nov 2020 07:37:20 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C0CC2071A for ; Fri, 6 Nov 2020 07:37:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C0CC2071A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ilande.co.uk Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:55070 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kawJC-00045W-Fg for qemu-devel@archiver.kernel.org; Fri, 06 Nov 2020 02:37:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41526) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kawHQ-0003Qv-Ud; Fri, 06 Nov 2020 02:35:28 -0500 Received: from mail.ilande.co.uk ([2001:41c9:1:41f::167]:38036 helo=mail.default.ilande.uk0.bigv.io) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kawHO-0003l6-Vw; Fri, 06 Nov 2020 02:35:28 -0500 Received: from host81-158-111-11.range81-158.btcentralplus.com ([81.158.111.11] helo=[192.168.1.65]) by mail.default.ilande.uk0.bigv.io with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1kawHX-0007eV-RA; Fri, 06 Nov 2020 07:35:36 +0000 To: Thomas Huth , armbru@redhat.com, david@gibson.dropbear.id.au, atar4qemu@gmail.com, qemu-devel@nongnu.org, qemu-ppc@nongnu.org References: <20200926140216.7368-1-mark.cave-ayland@ilande.co.uk> <20200926140216.7368-6-mark.cave-ayland@ilande.co.uk> <16f13e17-37cb-a238-4e2a-9a945649cafd@redhat.com> <24aca485-fe87-8aab-7554-ba8dc1a3bbb3@ilande.co.uk> <19068e17-21f0-75a5-f7df-1b11404008c6@redhat.com> From: Mark Cave-Ayland Message-ID: Date: Fri, 6 Nov 2020 07:35:18 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <19068e17-21f0-75a5-f7df-1b11404008c6@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 81.158.111.11 X-SA-Exim-Mail-From: mark.cave-ayland@ilande.co.uk Subject: Re: [PATCH v2 5/6] macio: don't reference serial_hd() directly within the device X-SA-Exim-Version: 4.2.1 (built Wed, 08 May 2019 21:11:16 +0000) X-SA-Exim-Scanned: Yes (on mail.default.ilande.uk0.bigv.io) Received-SPF: pass client-ip=2001:41c9:1:41f::167; envelope-from=mark.cave-ayland@ilande.co.uk; helo=mail.default.ilande.uk0.bigv.io X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 05/11/2020 05:31, Thomas Huth wrote: >> (goes and looks) >> >> Ah okay it appears to be because the object property link to the PIC is >> missing, which is to be expected as it is only present on the Mac machines. >> >> With the latest round of QOM updates I can see the solution but it's >> probably a bit much now that we've reached rc-0. The easiest thing for the >> moment is to switch user_creatable back to false if this is causing an issue. > > +1 for setting user_creatable back to false ... can you send a patch or > shall I prepare one? No that's fine, I can come up with a fix over the next couple of days. >> Just out of interest how did you find this? My new workflow involves a local >> "make check" with all ppc targets and a pass through Travis-CI and it didn't >> show up there for me (or indeed Peter's pre-merge tests). > > I've found it with the scripts/device-crash-test script. (You currently need > to apply Eduardo's patch "Check if path is actually an executable file" on > top first to run it) Have you got a link for this? I've tried doing some basic searches in my email client and couldn't easily spot it... ATB, Mark.