From: Eric Blake <eblake@redhat.com>
To: John Snow <jsnow@redhat.com>,
Andrew Baumann <Andrew.Baumann@microsoft.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "famz@redhat.com" <famz@redhat.com>
Subject: Re: [Qemu-devel] Disable image locking for snapshot drive?
Date: Tue, 18 Jul 2017 10:07:05 -0500 [thread overview]
Message-ID: <edae6aa7-34ef-a3a8-94e0-175f05728345@redhat.com> (raw)
In-Reply-To: <1263c0a6-263f-0b3b-c84a-f882df33856b@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 972 bytes --]
On 07/17/2017 07:33 PM, John Snow wrote:
>
>
> On 07/17/2017 07:30 PM, Andrew Baumann via Qemu-devel wrote:
>> Hi all,
>>
>> I'm running a recent Linux build of qemu on Windows Subsystem for Linux (WSL) which doesn't appear to implement file locking:
>>
>> $ qemu-system-aarch64 ... -drive file=test.vhdx,if=none,id=hd0 -device virtio-blk-pci,drive=hd0
>> qemu-system-aarch64: -drive file=test.vhdx,if=none,id=hd0: Failed to unlock byte 100
Does WSL implement fcntl(F_SETLK) but not fcntl(F_OFD_SETLK)? We
already have code in place for compiling when F_OFD_SETLK is not
supported (which makes lock=auto do nothing, and issues a warning that
F_SETLK locks may be ineffective when locks are explicitly requested),
do we need to just expand that code into a runtime test of whether
F_OFD_SETLK appears to be unsupported?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
next prev parent reply other threads:[~2017-07-18 15:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-17 23:30 [Qemu-devel] Disable image locking for snapshot drive? Andrew Baumann
2017-07-18 0:33 ` John Snow
2017-07-18 2:19 ` Andrew Baumann
2017-07-18 15:07 ` Eric Blake [this message]
2017-07-18 16:19 ` Andrew Baumann
2017-07-20 6:53 ` Fam Zheng
2017-07-20 21:49 ` Andrew Baumann
2017-07-21 1:46 ` Fam Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edae6aa7-34ef-a3a8-94e0-175f05728345@redhat.com \
--to=eblake@redhat.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).