From: Daniel Henrique Barboza <danielhb413@gmail.com>
To: Khem Raj <raj.khem@gmail.com>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [PATCH v2] ppc: Include asm/ptrace.h for pt_regs struct definition
Date: Mon, 14 Mar 2022 14:58:52 -0300 [thread overview]
Message-ID: <edb07e42-fbe0-2eed-48cb-adeade84d416@gmail.com> (raw)
In-Reply-To: <20220314172508.816110-1-raj.khem@gmail.com>
On 3/14/22 14:25, Khem Raj wrote:
> Fixes
> ../qemu-6.2.0/linux-user/host/ppc64/../ppc/host-signal.h:16:32: error: incomplete definition of type 'struct pt_regs'
> return uc->uc_mcontext.regs->nip;
> ~~~~~~~~~~~~~~~~~~~~^
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> Cc: Peter Maydell <peter.maydell@linaro.org>
> Cc: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Cc: Richard Henderson <richard.henderson@linaro.org>
> ---
> v2: Drop ifdef __powerpc__
>
> linux-user/include/host/ppc/host-signal.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/linux-user/include/host/ppc/host-signal.h b/linux-user/include/host/ppc/host-signal.h
> index b80384d135..ec6166ed66 100644
> --- a/linux-user/include/host/ppc/host-signal.h
> +++ b/linux-user/include/host/ppc/host-signal.h
> @@ -11,6 +11,9 @@
> #ifndef PPC_HOST_SIGNAL_H
> #define PPC_HOST_SIGNAL_H
>
> +/* needed for pt_regs */
> +#include <asm/ptrace.h>
> +
I am intrigued about why we didn't hit this before, especially considering that ppc64 header is just a
pointer to this file.
I looked it up and didn't find why. This change seems harmless to me though.
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
> /* The third argument to a SA_SIGINFO handler is ucontext_t. */
> typedef ucontext_t host_sigcontext;
>
next prev parent reply other threads:[~2022-03-14 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 17:25 [PATCH v2] ppc: Include asm/ptrace.h for pt_regs struct definition Khem Raj
2022-03-14 17:58 ` Daniel Henrique Barboza [this message]
2022-03-14 18:06 ` Peter Maydell
2022-03-14 19:02 ` Daniel P. Berrangé
2022-03-14 19:18 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edb07e42-fbe0-2eed-48cb-adeade84d416@gmail.com \
--to=danielhb413@gmail.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=raj.khem@gmail.com \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).