From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Manning <gmanning@rapitasystems.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v2 1/1] plugins: fix win plugin tests on cross compile
Date: Thu, 9 Nov 2023 10:32:44 +0100 [thread overview]
Message-ID: <edbf6575-08cf-49a5-8ac9-caf65d90c63a@redhat.com> (raw)
In-Reply-To: <20231109092418.84-2-gmanning@rapitasystems.com>
On 11/9/23 10:24, Greg Manning wrote:
> t += shared_module(i, files(i + '.c') + '../../contrib/plugins/win32_linker.c',
> include_directories: '../../include/qemu',
> - objects: [win32_qemu_plugin_api_lib],
> + link_depends: [win32_qemu_plugin_api_lib],
> + link_args: ['-Lplugins', '-lqemu_plugin_api'],
> dependencies: glib)
Does it work if you use win32_qemu_plugin_api_lib.full_path() for the
link_args? (If so it can be fixed when applying).
Paolo
next prev parent reply other threads:[~2023-11-09 9:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 9:24 [PATCH v2 0/1] plugins: fix win plugin tests on cross compile Greg Manning
2023-11-09 9:24 ` [PATCH v2 1/1] " Greg Manning
2023-11-09 9:32 ` Paolo Bonzini [this message]
2023-11-09 12:28 ` Greg Manning
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edbf6575-08cf-49a5-8ac9-caf65d90c63a@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=gmanning@rapitasystems.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).