From: Paolo Bonzini <pbonzini@redhat.com>
To: Claudio Fontana <cfontana@suse.de>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Pavel Dovgalyuk" <dovgaluk@ispras.ru>,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <rth@twiddle.net>
Subject: Re: [PATCH v3 3/3] replay: do not build if TCG is not available
Date: Tue, 13 Oct 2020 19:12:43 +0200 [thread overview]
Message-ID: <edc078b6-71b4-0650-1c23-fd437cd3fd25@redhat.com> (raw)
In-Reply-To: <20201013143806.14321-4-cfontana@suse.de>
On 13/10/20 16:38, Claudio Fontana wrote:
> +void bdrv_bh_schedule_oneshot(AioContext *ctx, QEMUBHFunc *cb, void *opaque)
> +{
> + if (replay_events_enabled()) {
> + replay_bh_schedule_oneshot_event(ctx, cb, opaque);
> + } else {
> + aio_bh_schedule_oneshot(ctx, cb, opaque);
> + }
> +}
> +
> +void bdrv_bh_schedule(QEMUBH *bh)
> +{
> + if (replay_events_enabled()) {
> + replay_bh_schedule_event(bh);
> + } else {
> + qemu_bh_schedule(bh);
> + }
> +}
This is definitely better, but I'll defer to Kevin with respect to the
naming of the function; having a bdrv_* function that has nothing to do
with the block layer is still smelly of a sub-optimal API, and I'm not
sure why the API change belongs in the series.
Paolo
next prev parent reply other threads:[~2020-10-13 17:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 14:38 [PATCH v3 0/3] unbreak non-tcg builds Claudio Fontana
2020-10-13 14:38 ` [PATCH v3 1/3] tests/Makefile.include: " Claudio Fontana
2020-10-13 14:38 ` [PATCH v3 2/3] qtest: unbreak non-TCG builds in bios-tables-test Claudio Fontana
2020-10-13 14:38 ` [PATCH v3 3/3] replay: do not build if TCG is not available Claudio Fontana
2020-10-13 17:12 ` Paolo Bonzini [this message]
2020-10-13 17:17 ` Claudio Fontana
2020-10-13 17:25 ` Paolo Bonzini
2020-10-13 17:37 ` Claudio Fontana
2020-10-13 14:55 ` [PATCH v3 0/3] unbreak non-tcg builds Philippe Mathieu-Daudé
2020-10-13 16:47 ` Claudio Fontana
2020-10-13 16:51 ` Daniel P. Berrangé
2020-10-26 15:28 ` Claudio Fontana
2020-10-26 15:34 ` Claudio Fontana
2021-01-10 17:51 ` Claudio Fontana
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc078b6-71b4-0650-1c23-fd437cd3fd25@redhat.com \
--to=pbonzini@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=cfontana@suse.de \
--cc=dovgaluk@ispras.ru \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).