From: Paolo Bonzini <pbonzini@redhat.com>
To: P J P <ppandit@redhat.com>, Amit Shah <amit.shah@redhat.com>
Cc: Li Qiang <liqiang6-s@360.cn>,
Qemu Developers <qemu-devel@nongnu.org>,
Laszlo Ersek <lersek@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4] scsi: esp: check length before dma read
Date: Fri, 17 Jun 2016 10:26:32 +0200 [thread overview]
Message-ID: <edc12e15-5842-3b37-12de-c4a5ac7a4e9d@redhat.com> (raw)
In-Reply-To: <alpine.LFD.2.20.1606171023270.19175@wniryva>
On 17/06/2016 10:16, P J P wrote:
> +-- On Fri, 17 Jun 2016, Amit Shah wrote --+
> | This was flagged as an incompatibility in the vmstate by a nightly run
> | of the vmstate checker:
> |
> | Section "esp" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
> | Section "dc390" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
> | Section "am53c974" Description "esp" Field "cmdbuf" size mismatch: 16 , 32
>
> Probably vmstate file needs to be regenerated?
No, that's not what that means. It means that your patch broke
migration compatibility. I've posted a patch to just remove the code
(which also has the effect of reverting your patch and mine).
Paolo
next prev parent reply other threads:[~2016-06-17 8:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-15 17:36 [Qemu-devel] [PATCH v4] scsi: esp: check length before dma read P J P
2016-06-17 4:19 ` Amit Shah
2016-06-17 8:16 ` P J P
2016-06-17 8:26 ` Paolo Bonzini [this message]
2016-06-17 8:21 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edc12e15-5842-3b37-12de-c4a5ac7a4e9d@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=lersek@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).