Re: [PATCH for-10.0 02/25] fpu: Check for default_nan_mode before calling pickNaNMulAdd

[Richard Henderson <richard.henderson@linaro.org>]

On 11/28/24 04:42, Peter Maydell wrote:
> If the target sets default_nan_mode then we're always going to return
> the default NaN, and pickNaNMulAdd() no longer has any side effects.
> For consistency with pickNaN(), check for default_nan_mode before
> calling pickNaNMulAdd().
> 
> When we convert pickNaNMulAdd() to allow runtime selection of the NaN
> propagation rule, this means we won't have to make the targets which
> use default_nan_mode also set a propagation rule.
> 
> Since RiscV always uses default_nan_mode, this allows us to remove
> its ifdef case from pickNaNMulAdd().
> 
> Signed-off-by: Peter Maydell<peter.maydell@linaro.org>
> ---
>   fpu/softfloat-parts.c.inc      | 8 ++++++--
>   fpu/softfloat-specialize.c.inc | 9 +++++++--
>   2 files changed, 13 insertions(+), 4 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~