From: Fiona Ebner <f.ebner@proxmox.com>
To: Mike Maslenkin <mike.maslenkin@gmail.com>
Cc: John Snow <jsnow@redhat.com>,
QEMU Developers <qemu-devel@nongnu.org>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>,
Thomas Lamprecht <t.lamprecht@proxmox.com>,
Aaron Lauterer <a.lauterer@proxmox.com>
Subject: Re: Lost partition tables on ide-hd + ahci drive
Date: Thu, 16 Feb 2023 16:25:46 +0100 [thread overview]
Message-ID: <edd04a3f-6ae7-fd28-81c9-25a2614076f6@proxmox.com> (raw)
In-Reply-To: <CAL77WPAdDyKFWP_Dqsz_xr7OCzHLTkw6VbYDMGobi8kek4e_8A@mail.gmail.com>
Am 16.02.23 um 15:17 schrieb Mike Maslenkin:
> Does additional comparison make a sense here: check for LBA == 0 and
> then check MBR signature bytes.
> Additionally it’s easy to check buffer_is_zero() result or even print
> FIS contents under these conditions.
> Data looks like a part of guest memory of 64bit Windows.
Thank you for the suggestion! I'll think about adding such a check and
dumping of FIS contents in a custom build for affected users. But in
general it would be too much noise for non-MBR cases: e.g. on a disk
formatted with ext4 (without any partitions), Linux will write to sector
0 on every startup and shutdown.
Best Regards,
Fiona
next prev parent reply other threads:[~2023-02-16 15:26 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 12:08 Lost partition tables on ide-hd + ahci drive Fiona Ebner
2023-02-14 18:21 ` John Snow
2023-02-15 10:53 ` Fiona Ebner
2023-02-15 21:47 ` John Snow
2023-02-16 8:58 ` Fiona Ebner
2023-02-16 14:17 ` Mike Maslenkin
2023-02-16 15:25 ` Fiona Ebner [this message]
2023-02-16 16:15 ` Mike Maslenkin
2023-02-17 12:25 ` Fiona Ebner
2023-02-17 13:40 ` Fiona Ebner
2023-02-17 21:22 ` Mike Maslenkin
2023-08-23 8:47 ` Fiona Ebner
2023-08-23 9:17 ` Fiona Ebner
2023-08-26 18:07 ` Mike Maslenkin
2023-02-17 9:44 ` Aaron Lauterer
2023-06-14 14:48 ` Simon J. Rowe
2023-06-15 7:04 ` Fiona Ebner
2023-06-15 8:24 ` Simon Rowe
2023-07-27 13:22 ` Simon Rowe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edd04a3f-6ae7-fd28-81c9-25a2614076f6@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=jsnow@redhat.com \
--cc=mike.maslenkin@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).