From: Richard Henderson <richard.henderson@linaro.org>
To: Idan Horowitz <idan.horowitz@gmail.com>, qemu-arm@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA
Date: Tue, 29 Mar 2022 13:09:05 -0600 [thread overview]
Message-ID: <ede38e3b-5207-52fe-4c02-72a4bbe1cf20@linaro.org> (raw)
In-Reply-To: <20220327093427.1548629-4-idan.horowitz@gmail.com>
On 3/27/22 03:34, Idan Horowitz wrote:
> As per the AArch64.S2Walk() psuedo-code in the ARMv8 ARM, the final
> decision as to the output address's PA space based on the SA/SW/NSA/NSA
> bits needs to take the input IPA's PA space into account, and not the
> PA space of the result of the stage 2 walk itself.
>
> Signed-off-by: Idan Horowitz <idan.horowitz@gmail.com>
I believe I follow: because the walk uses walkstate.address.paddress.paspace, the ipa
input parameter is unchanged, and it is ipa that is passed to
AArch64.S2NextWalkStateLast() to form the output address.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2022-03-29 19:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-27 9:34 [PATCH 0/3] Bug fixes related to secure 2 stage translation Idan Horowitz
2022-03-27 9:34 ` [PATCH 1/3] target/arm: Check VSTCR.SW when assigning the stage 2 output PA space Idan Horowitz
2022-03-27 14:24 ` Rémi Denis-Courmont
2022-03-29 14:59 ` Richard Henderson
2022-03-29 14:59 ` Richard Henderson
2022-03-27 9:34 ` [PATCH 2/3] target/arm: Take VSTCR.SW, VTCR.NSW into account in final stage 2 walk Idan Horowitz
2022-03-29 16:36 ` Richard Henderson
2022-03-27 9:34 ` [PATCH 3/3] target/arm: Determine final stage 2 output PA space based on original IPA Idan Horowitz
2022-03-29 19:09 ` Richard Henderson [this message]
2022-03-29 20:18 ` Idan Horowitz
2022-03-31 8:46 ` Peter Maydell
2022-03-31 8:46 ` [PATCH 0/3] Bug fixes related to secure 2 stage translation Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede38e3b-5207-52fe-4c02-72a4bbe1cf20@linaro.org \
--to=richard.henderson@linaro.org \
--cc=idan.horowitz@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).