From: Paolo Bonzini <pbonzini@redhat.com>
To: Greg Kurz <groug@kaod.org>, Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] block: fix QEMU crash with scsi-hd and drive_del
Date: Thu, 24 May 2018 08:04:59 +0200 [thread overview]
Message-ID: <ede94233-e969-0de4-c8ee-a9ff91ce808a@redhat.com> (raw)
In-Reply-To: <20180523164610.09ec083b@bahia.lan>
On 23/05/2018 16:46, Greg Kurz wrote:
> Maybe change bdrv_root_unref_child() to ensure we don't call
> bdrv_close() with pending I/O requests ?
>
> void bdrv_root_unref_child(BdrvChild *child)
> {
> BlockDriverState *child_bs;
>
> child_bs = child->bs;
> + bdrv_drained_begin(child_bs);
> bdrv_detach_child(child);
> + bdrv_drained_end(child_bs);
> bdrv_unref(child_bs);
> }
Maybe bdrv_detach_child should do it.
Paolo
next prev parent reply other threads:[~2018-05-24 6:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-16 11:21 [Qemu-devel] [PATCH] block: fix QEMU crash with scsi-hd and drive_del Greg Kurz
2018-05-16 15:41 ` Greg KH
2018-05-16 16:53 ` Greg Kurz
2018-05-18 15:32 ` Stefan Hajnoczi
2018-05-23 14:46 ` Greg Kurz
2018-05-24 6:04 ` Paolo Bonzini [this message]
2018-05-24 8:05 ` Stefan Hajnoczi
2018-05-24 8:32 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ede94233-e969-0de4-c8ee-a9ff91ce808a@redhat.com \
--to=pbonzini@redhat.com \
--cc=groug@kaod.org \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).