* [PATCH] hw/pci: Remove unused pcie_chassis_find_slot
@ 2024-09-18 23:47 dave
2024-10-02 10:42 ` Thomas Huth
2024-10-03 21:15 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: dave @ 2024-09-18 23:47 UTC (permalink / raw)
To: mst, marcel.apfelbaum, qemu-devel; +Cc: Dr. David Alan Gilbert
From: "Dr. David Alan Gilbert" <dave@treblig.org>
pcie_chassis_find_slot has been unused since it was added.
Remove it.
Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
---
hw/pci/pcie_port.c | 10 ----------
include/hw/pci/pcie_port.h | 1 -
2 files changed, 11 deletions(-)
diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index 20ff2b39e8..9f978ba164 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -92,16 +92,6 @@ static PCIESlot *pcie_chassis_find_slot_with_chassis(struct PCIEChassis *c,
return s;
}
-PCIESlot *pcie_chassis_find_slot(uint8_t chassis_number, uint16_t slot)
-{
- struct PCIEChassis *c;
- c = pcie_chassis_find(chassis_number);
- if (!c) {
- return NULL;
- }
- return pcie_chassis_find_slot_with_chassis(c, slot);
-}
-
int pcie_chassis_add_slot(struct PCIESlot *slot)
{
struct PCIEChassis *c;
diff --git a/include/hw/pci/pcie_port.h b/include/hw/pci/pcie_port.h
index 90e6cf45b8..7cd7af8cfa 100644
--- a/include/hw/pci/pcie_port.h
+++ b/include/hw/pci/pcie_port.h
@@ -72,7 +72,6 @@ struct PCIESlot {
};
void pcie_chassis_create(uint8_t chassis_number);
-PCIESlot *pcie_chassis_find_slot(uint8_t chassis, uint16_t slot);
int pcie_chassis_add_slot(struct PCIESlot *slot);
void pcie_chassis_del_slot(PCIESlot *s);
--
2.46.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/pci: Remove unused pcie_chassis_find_slot
2024-09-18 23:47 [PATCH] hw/pci: Remove unused pcie_chassis_find_slot dave
@ 2024-10-02 10:42 ` Thomas Huth
2024-10-03 21:15 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2024-10-02 10:42 UTC (permalink / raw)
To: dave, mst, marcel.apfelbaum, qemu-devel, QEMU Trivial
On 19/09/2024 01.47, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> pcie_chassis_find_slot has been unused since it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> hw/pci/pcie_port.c | 10 ----------
> include/hw/pci/pcie_port.h | 1 -
> 2 files changed, 11 deletions(-)
>
> diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
> index 20ff2b39e8..9f978ba164 100644
> --- a/hw/pci/pcie_port.c
> +++ b/hw/pci/pcie_port.c
> @@ -92,16 +92,6 @@ static PCIESlot *pcie_chassis_find_slot_with_chassis(struct PCIEChassis *c,
> return s;
> }
>
> -PCIESlot *pcie_chassis_find_slot(uint8_t chassis_number, uint16_t slot)
> -{
> - struct PCIEChassis *c;
> - c = pcie_chassis_find(chassis_number);
> - if (!c) {
> - return NULL;
> - }
> - return pcie_chassis_find_slot_with_chassis(c, slot);
> -}
> -
> int pcie_chassis_add_slot(struct PCIESlot *slot)
> {
> struct PCIEChassis *c;
> diff --git a/include/hw/pci/pcie_port.h b/include/hw/pci/pcie_port.h
> index 90e6cf45b8..7cd7af8cfa 100644
> --- a/include/hw/pci/pcie_port.h
> +++ b/include/hw/pci/pcie_port.h
> @@ -72,7 +72,6 @@ struct PCIESlot {
> };
>
> void pcie_chassis_create(uint8_t chassis_number);
> -PCIESlot *pcie_chassis_find_slot(uint8_t chassis, uint16_t slot);
> int pcie_chassis_add_slot(struct PCIESlot *slot);
> void pcie_chassis_del_slot(PCIESlot *s);
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] hw/pci: Remove unused pcie_chassis_find_slot
2024-09-18 23:47 [PATCH] hw/pci: Remove unused pcie_chassis_find_slot dave
2024-10-02 10:42 ` Thomas Huth
@ 2024-10-03 21:15 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2024-10-03 21:15 UTC (permalink / raw)
To: dave, mst, marcel.apfelbaum, qemu-devel
On 19/9/24 01:47, dave@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <dave@treblig.org>
>
> pcie_chassis_find_slot has been unused since it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <dave@treblig.org>
> ---
> hw/pci/pcie_port.c | 10 ----------
> include/hw/pci/pcie_port.h | 1 -
> 2 files changed, 11 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-03 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-18 23:47 [PATCH] hw/pci: Remove unused pcie_chassis_find_slot dave
2024-10-02 10:42 ` Thomas Huth
2024-10-03 21:15 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).