[PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[Cédric Le Goater]

Hello,

All PPC files should now be correctly assigned to some entry. 

Cheers,

C.

Cédric Le Goater (8):
  ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h
    header
  MAINTAINERS: Adjust file list for PPC ref405ep machine
  MAINTAINERS: Adjust file list for PPC 4xx CPUs
  MAINTAINERS: Adjust file list for PPC e500 machines
  MAINTAINERS: Adjust file list for PPC pseries machine
  MAINTAINERS: Add fw_cfg.c to PPC mac99 machine
  MAINTAINERS: Add PPC common files to PowerPC TCG CPUs
  MAINTAINERS: Update PPC TCG target with tests

 MAINTAINERS            | 19 +++++++++++++++++--
 hw/ppc/ppc440_bamboo.c |  1 -
 hw/ppc/virtex_ml507.c  |  1 -
 3 files changed, 17 insertions(+), 4 deletions(-)

-- 
2.41.0

[PATCH 1/8] ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header

[Cédric Le Goater]

Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> (odd fixer:virtex_ml507)
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 hw/ppc/ppc440_bamboo.c | 1 -
 hw/ppc/virtex_ml507.c  | 1 -
 2 files changed, 2 deletions(-)

diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c
index 45f409c83862..a189942de4cf 100644
--- a/hw/ppc/ppc440_bamboo.c
+++ b/hw/ppc/ppc440_bamboo.c
@@ -24,7 +24,6 @@
 #include "elf.h"
 #include "hw/char/serial.h"
 #include "hw/ppc/ppc.h"
-#include "ppc405.h"
 #include "sysemu/sysemu.h"
 #include "sysemu/reset.h"
 #include "hw/sysbus.h"
diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
index f2f81bd4259c..d02f330650fc 100644
--- a/hw/ppc/virtex_ml507.c
+++ b/hw/ppc/virtex_ml507.c
@@ -43,7 +43,6 @@
 #include "hw/ppc/ppc.h"
 #include "hw/ppc/ppc4xx.h"
 #include "hw/qdev-properties.h"
-#include "ppc405.h"
 
 #include <libfdt.h>
 
-- 
2.41.0

[PATCH 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

[Cédric Le Goater]

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 355b1960ce46..3f90264203cc 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1345,7 +1345,7 @@ PowerPC Machines
 405 (ref405ep)
 L: qemu-ppc@nongnu.org
 S: Orphan
-F: hw/ppc/ppc405_boards.c
+F: hw/ppc/ppc405*
 
 Bamboo
 L: qemu-ppc@nongnu.org
-- 
2.41.0

[PATCH 3/8] MAINTAINERS: Adjust file list for PPC 4xx CPUs

[Cédric Le Goater]

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3f90264203cc..2bf7af9bd150 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1960,7 +1960,9 @@ F: docs/specs/acpi_hest_ghes.rst
 ppc4xx
 L: qemu-ppc@nongnu.org
 S: Orphan
-F: hw/ppc/ppc4*.c
+F: hw/ppc/ppc4xx*.c
+F: hw/ppc/ppc440_uc.c
+F: hw/ppc/ppc440.h
 F: hw/i2c/ppc4xx_i2c.c
 F: include/hw/ppc/ppc4xx.h
 F: include/hw/i2c/ppc4xx_i2c.h
-- 
2.41.0

[PATCH 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

[Cédric Le Goater]

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2bf7af9bd150..23ce59995d59 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1357,6 +1357,7 @@ e500
 L: qemu-ppc@nongnu.org
 S: Orphan
 F: hw/ppc/e500*
+F: hw/ppc/ppce500_spin.c
 F: hw/gpio/mpc8xxx.c
 F: hw/i2c/mpc_i2c.c
 F: hw/net/fsl_etsec/
@@ -1366,6 +1367,7 @@ F: include/hw/pci-host/ppce500.h
 F: pc-bios/u-boot.e500
 F: hw/intc/openpic_kvm.h
 F: include/hw/ppc/openpic_kvm.h
+F: docs/system/ppc/ppce500.rst
 
 mpc8544ds
 L: qemu-ppc@nongnu.org
-- 
2.41.0

[PATCH 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

[Cédric Le Goater]

The fdt.{c.h} files provide a helper routine used by the pseries and
pnv machines. Attached it to the list of the larger one: pseries.

Protected Execution Facility (PEF) is the confidential guest support
for PPC pseries machines.

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 23ce59995d59..b3ba402f7943 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1440,6 +1440,10 @@ F: hw/*/spapr*
 F: include/hw/*/spapr*
 F: hw/*/xics*
 F: include/hw/*/xics*
+F: include/hw/ppc/fdt.h
+F: hw/ppc/fdt.c
+F: include/hw/ppc/pef.h
+F: hw/ppc/pef.c
 F: pc-bios/slof.bin
 F: docs/system/ppc/pseries.rst
 F: docs/specs/ppc-spapr-*
-- 
2.41.0

[PATCH 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

[Cédric Le Goater]

The hw/ppc/fw_cfg.c file contains the implementation of
fw_cfg_arch_key_name(), used by the common nvram model. List it under
mac99 machine next to the mac_nvram model.

Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index b3ba402f7943..1f72931ac2a4 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1387,6 +1387,7 @@ F: hw/pci-bridge/dec.[hc]
 F: hw/misc/macio/
 F: hw/misc/mos6522.c
 F: hw/nvram/mac_nvram.c
+F: hw/ppc/fw_cfg.c
 F: hw/input/adb*
 F: include/hw/misc/macio/
 F: include/hw/misc/mos6522.h
-- 
2.41.0

[PATCH 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

[Cédric Le Goater]

Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 1f72931ac2a4..2d00d14ef226 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -307,6 +307,11 @@ F: target/ppc/
 F: hw/ppc/ppc.c
 F: hw/ppc/ppc_booke.c
 F: include/hw/ppc/ppc.h
+F: hw/ppc/meson.build
+F: hw/ppc/trace*
+F: configs/devices/ppc*
+F: docs/system/ppc/embedded.rst
+F: docs/system/target-ppc.rst
 
 RISC-V TCG CPUs
 M: Palmer Dabbelt <palmer@dabbelt.com>
-- 
2.41.0

[PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

[Cédric Le Goater]

Cc: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

diff --git a/MAINTAINERS b/MAINTAINERS
index 2d00d14ef226..9fe9294eccb9 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3550,6 +3550,7 @@ PPC TCG target
 M: Richard Henderson <richard.henderson@linaro.org>
 S: Odd Fixes
 F: tcg/ppc/
+F: tests/tcg/ppc*
 
 RISC-V TCG target
 M: Palmer Dabbelt <palmer@dabbelt.com>
-- 
2.41.0

Re: [PATCH 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

[Philippe Mathieu-Daudé]

Hi Cédric,

On 2/10/23 14:23, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce46..3f90264203cc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1345,7 +1345,7 @@ PowerPC Machines
>   405 (ref405ep)
>   L: qemu-ppc@nongnu.org
>   S: Orphan
> -F: hw/ppc/ppc405_boards.c
> +F: hw/ppc/ppc405*

Do you mind adding tests/avocado/ppc_405.py?

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

[Philippe Mathieu-Daudé]

On 2/10/23 14:23, Cédric Le Goater wrote:
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Re: [PATCH 1/8] ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h header

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com> (odd fixer:virtex_ml507)
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   hw/ppc/ppc440_bamboo.c | 1 -
>   hw/ppc/virtex_ml507.c  | 1 -
>   2 files changed, 2 deletions(-)
> 
> diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c
> index 45f409c83862..a189942de4cf 100644
> --- a/hw/ppc/ppc440_bamboo.c
> +++ b/hw/ppc/ppc440_bamboo.c
> @@ -24,7 +24,6 @@
>   #include "elf.h"
>   #include "hw/char/serial.h"
>   #include "hw/ppc/ppc.h"
> -#include "ppc405.h"
>   #include "sysemu/sysemu.h"
>   #include "sysemu/reset.h"
>   #include "hw/sysbus.h"
> diff --git a/hw/ppc/virtex_ml507.c b/hw/ppc/virtex_ml507.c
> index f2f81bd4259c..d02f330650fc 100644
> --- a/hw/ppc/virtex_ml507.c
> +++ b/hw/ppc/virtex_ml507.c
> @@ -43,7 +43,6 @@
>   #include "hw/ppc/ppc.h"
>   #include "hw/ppc/ppc4xx.h"
>   #include "hw/qdev-properties.h"
> -#include "ppc405.h"
>   
>   #include <libfdt.h>
>   

Re: [PATCH 2/8] MAINTAINERS: Adjust file list for PPC ref405ep machine

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 355b1960ce46..3f90264203cc 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1345,7 +1345,7 @@ PowerPC Machines
>   405 (ref405ep)
>   L: qemu-ppc@nongnu.org
>   S: Orphan
> -F: hw/ppc/ppc405_boards.c
> +F: hw/ppc/ppc405*
>   
>   Bamboo
>   L: qemu-ppc@nongnu.org

Re: [PATCH 3/8] MAINTAINERS: Adjust file list for PPC 4xx CPUs

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3f90264203cc..2bf7af9bd150 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1960,7 +1960,9 @@ F: docs/specs/acpi_hest_ghes.rst
>   ppc4xx
>   L: qemu-ppc@nongnu.org
>   S: Orphan
> -F: hw/ppc/ppc4*.c
> +F: hw/ppc/ppc4xx*.c
> +F: hw/ppc/ppc440_uc.c
> +F: hw/ppc/ppc440.h
>   F: hw/i2c/ppc4xx_i2c.c
>   F: include/hw/ppc/ppc4xx.h
>   F: include/hw/i2c/ppc4xx_i2c.h

Re: [PATCH 4/8] MAINTAINERS: Adjust file list for PPC e500 machines

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2bf7af9bd150..23ce59995d59 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1357,6 +1357,7 @@ e500
>   L: qemu-ppc@nongnu.org
>   S: Orphan
>   F: hw/ppc/e500*
> +F: hw/ppc/ppce500_spin.c
>   F: hw/gpio/mpc8xxx.c
>   F: hw/i2c/mpc_i2c.c
>   F: hw/net/fsl_etsec/
> @@ -1366,6 +1367,7 @@ F: include/hw/pci-host/ppce500.h
>   F: pc-bios/u-boot.e500
>   F: hw/intc/openpic_kvm.h
>   F: include/hw/ppc/openpic_kvm.h
> +F: docs/system/ppc/ppce500.rst
>   
>   mpc8544ds
>   L: qemu-ppc@nongnu.org

Re: [PATCH 5/8] MAINTAINERS: Adjust file list for PPC pseries machine

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> The fdt.{c.h} files provide a helper routine used by the pseries and
> pnv machines. Attached it to the list of the larger one: pseries.
> 
> Protected Execution Facility (PEF) is the confidential guest support
> for PPC pseries machines.
> 
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 23ce59995d59..b3ba402f7943 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1440,6 +1440,10 @@ F: hw/*/spapr*
>   F: include/hw/*/spapr*
>   F: hw/*/xics*
>   F: include/hw/*/xics*
> +F: include/hw/ppc/fdt.h
> +F: hw/ppc/fdt.c
> +F: include/hw/ppc/pef.h
> +F: hw/ppc/pef.c
>   F: pc-bios/slof.bin
>   F: docs/system/ppc/pseries.rst
>   F: docs/specs/ppc-spapr-*

Re: [PATCH 6/8] MAINTAINERS: Add fw_cfg.c to PPC mac99 machine

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> The hw/ppc/fw_cfg.c file contains the implementation of
> fw_cfg_arch_key_name(), used by the common nvram model. List it under
> mac99 machine next to the mac_nvram model.
> 
> Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b3ba402f7943..1f72931ac2a4 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1387,6 +1387,7 @@ F: hw/pci-bridge/dec.[hc]
>   F: hw/misc/macio/
>   F: hw/misc/mos6522.c
>   F: hw/nvram/mac_nvram.c
> +F: hw/ppc/fw_cfg.c
>   F: hw/input/adb*
>   F: include/hw/misc/macio/
>   F: include/hw/misc/mos6522.h

Re: [PATCH 7/8] MAINTAINERS: Add PPC common files to PowerPC TCG CPUs

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---
>   MAINTAINERS | 5 +++++
>   1 file changed, 5 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 1f72931ac2a4..2d00d14ef226 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -307,6 +307,11 @@ F: target/ppc/
>   F: hw/ppc/ppc.c
>   F: hw/ppc/ppc_booke.c
>   F: include/hw/ppc/ppc.h
> +F: hw/ppc/meson.build
> +F: hw/ppc/trace*
> +F: configs/devices/ppc*

Other archs seems to put the configs/devices/* file either on a "TCG CPUs"
entry or some other entry related to a machine type (e.g. MIPS). We don't
have an "Overall PPC Machines" entry like MIPS does, so adding it under
TCG CPUs works for me.


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>



> +F: docs/system/ppc/embedded.rst
> +F: docs/system/target-ppc.rst
>   
>   RISC-V TCG CPUs
>   M: Palmer Dabbelt <palmer@dabbelt.com>

Re: [PATCH 8/8] MAINTAINERS: Update PPC TCG target with tests

[Daniel Henrique Barboza]

On 10/2/23 09:23, Cédric Le Goater wrote:
> Cc: Richard Henderson <richard.henderson@linaro.org>
> Signed-off-by: Cédric Le Goater <clg@kaod.org>
> ---

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

>   MAINTAINERS | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2d00d14ef226..9fe9294eccb9 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3550,6 +3550,7 @@ PPC TCG target
>   M: Richard Henderson <richard.henderson@linaro.org>
>   S: Odd Fixes
>   F: tcg/ppc/
> +F: tests/tcg/ppc*
>   
>   RISC-V TCG target
>   M: Palmer Dabbelt <palmer@dabbelt.com>

Re: [PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[Cédric Le Goater]

Adding Cc: qemu-trivial@nongnu.org because these changes don't need to go
through the ppc tree.

On 10/2/23 14:23, Cédric Le Goater wrote:
> Hello,
> 
> All PPC files should now be correctly assigned to some entry.
> 
> Cheers,

Last patch should be dropped though. It is replaced by:

  https://lore.kernel.org/qemu-devel/20231018062401.20746-1-thuth@redhat.com/

Thanks,

C.



> C.
> 
> Cédric Le Goater (8):
>    ppc/{bamboo, virtex_ml507}: Remove useless dependency on ppc405.h
>      header
>    MAINTAINERS: Adjust file list for PPC ref405ep machine
>    MAINTAINERS: Adjust file list for PPC 4xx CPUs
>    MAINTAINERS: Adjust file list for PPC e500 machines
>    MAINTAINERS: Adjust file list for PPC pseries machine
>    MAINTAINERS: Add fw_cfg.c to PPC mac99 machine
>    MAINTAINERS: Add PPC common files to PowerPC TCG CPUs
>    MAINTAINERS: Update PPC TCG target with tests
> 
>   MAINTAINERS            | 19 +++++++++++++++++--
>   hw/ppc/ppc440_bamboo.c |  1 -
>   hw/ppc/virtex_ml507.c  |  1 -
>   3 files changed, 17 insertions(+), 4 deletions(-)
> 

Re: [PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[Michael Tokarev]

18.10.2023 09:38, Cédric Le Goater :
> 
> Adding Cc: qemu-trivial@nongnu.org because these changes don't need to go
> through the ppc tree.

Heh.  You guys puzzled me quite a bit ;)

Now this puzzle is complete.
Okay, let's pick whole bunch (together with follow-up changes by Thomas)
in the trivial-patches tree :)

/mjt

Re: [PATCH 0/8] MAINTAINERS: Collect unmaintained files under PPC entries

[Thomas Huth]

On 21/10/2023 13.44, Michael Tokarev wrote:
> 18.10.2023 09:38, Cédric Le Goater :
>>
>> Adding Cc: qemu-trivial@nongnu.org because these changes don't need to go
>> through the ppc tree.
> 
> Heh.  You guys puzzled me quite a bit ;)
> 
> Now this puzzle is complete.
> Okay, let's pick whole bunch (together with follow-up changes by Thomas)
> in the trivial-patches tree :)

Thanks for sorting it out :-)

  Thomas