From: Richard Henderson <richard.henderson@linaro.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Alexander Bulekov <alxndr@bu.edu>,
qemu-stable@nongnu.org, "Michael S. Tsirkin" <mst@redhat.com>
Subject: Re: [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field
Date: Fri, 17 Jul 2020 11:38:30 -0700 [thread overview]
Message-ID: <edf80e5a-b698-b9dc-f867-8fa920f41786@linaro.org> (raw)
In-Reply-To: <20200717181724.27493-1-f4bug@amsat.org>
On 7/17/20 11:17 AM, Philippe Mathieu-Daudé wrote:
> case MCH_HOST_BRIDGE_PCIEXBAR_LENGTH_RVD:
> - default:
> - abort();
> + qemu_log_mask(LOG_GUEST_ERROR, "Q35: Reserved PCIEXBAR LENGTH\n");
> + return;
> }
Did you really want to remove the default case?
I guess the mask means that only *_RVD is left over, but the default sorta
self-documents that.
Either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2020-07-17 18:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 18:17 [RFC PATCH-for-5.1] hw/pci-host/q35: Ignore write of reserved PCIEXBAR LENGTH field Philippe Mathieu-Daudé
2020-07-17 18:38 ` Richard Henderson [this message]
2020-07-17 19:39 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edf80e5a-b698-b9dc-f867-8fa920f41786@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alxndr@bu.edu \
--cc=f4bug@amsat.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).