From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56093) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bCUj4-00072t-S2 for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:28:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bCUj2-00017S-HC for qemu-devel@nongnu.org; Mon, 13 Jun 2016 12:28:33 -0400 Sender: Paolo Bonzini References: <1463006384-7734-1-git-send-email-eblake@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 13 Jun 2016 18:28:19 +0200 MIME-Version: 1.0 In-Reply-To: <1463006384-7734-1-git-send-email-eblake@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH v4 00/11] nbd: tighter protocol compliance List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake , qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, alex@alex.org.uk On 12/05/2016 00:39, Eric Blake wrote: > Fix several corner-case bugs in our implementation of the NBD > protocol, both as client and as server. > > Depends on Kevin's block-next branch: > git://repo.or.cz/qemu/kevin.git block-next > > Also available as a tag at this location: > git fetch git://repo.or.cz/qemu/ericb.git nbd-flags-v4 > > Broken out of a larger v3 series[1], for easier review. There > are still some places where we aren't quite compliant (for example, > the protocol recommends that the client send NBD_OPT_ABORT before > dropping the connection after receiving a valid server response it > didn't like but which did not violate protocol), but later series > will tackle that. > > [1] https://lists.gnu.org/archive/html/qemu-devel/2016-04/msg03526.html > > Changes in v4: rebase to latest block-next > > 001/11:[----] [--] 'nbd: Use BDRV_REQ_FUA for better FUA where supported' Applied. > 002/11:[0004] [FC] 'nbd: More debug typo fixes, use correct formats' Applied. > 003/11:[----] [--] 'nbd: Quit server after any write error' Applied. > 004/11:[----] [--] 'nbd: Improve server handling of bogus commands' Applied with some changes, see reply to individual patch. > 005/11:[----] [--] 'nbd: Reject unknown request flags' Applied. > 006/11:[----] [--] 'nbd: Group all Linux-specific ioctl code in one place' Applied. > 007/11:[----] [--] 'nbd: Clean up ioctl handling of qemu-nbd -c' Applied. > 008/11:[----] [-C] 'nbd: Limit nbdflags to 16 bits' Doesn't apply anymore. > 009/11:[----] [--] 'nbd: Add qemu-nbd -D for human-readable description' Doesn't apply anymore. > 010/11:[----] [--] 'nbd: Detect servers that send unexpected error values' Applied. > 011/11:[----] [--] 'nbd: Avoid magic number for NBD max name size' Applied. I'll need a v5 of just patch 8 and patch 9; I'm queuing the rest and will send a pull request later this week. Thanks, Paolo