From: Jiaxun Yang <jiaxun.yang@flygoat.com>
To: "Marcin Nowakowski" <marcin.nowakowski@fungible.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [PATCH] target/mips: enable GINVx support for I6400 and I6500
Date: Mon, 10 Jul 2023 20:58:21 +0800 [thread overview]
Message-ID: <ee19d8a2-733a-23c9-cce9-db8b8dc0e253@flygoat.com> (raw)
In-Reply-To: <20230630072806.3093704-1-marcin.nowakowski@fungible.com>
在 2023/6/30 15:28, Marcin Nowakowski 写道:
> GINVI and GINVT operations are supported on MIPS I6400 and I6500 cores,
> so indicate that properly in CP0.Config5 register bits [16:15].
>
> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@fungible.com>
VZ is unimplemented in TCG so perhaps we should leave them as not supported?
Thanks
- Jiaxun
> ---
> target/mips/cpu-defs.c.inc | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target/mips/cpu-defs.c.inc b/target/mips/cpu-defs.c.inc
> index d45f245a67..da122e72d7 100644
> --- a/target/mips/cpu-defs.c.inc
> +++ b/target/mips/cpu-defs.c.inc
> @@ -709,7 +709,7 @@ const mips_def_t mips_defs[] =
> .CP0_Config4 = MIPS_CONFIG4 | (1U << CP0C4_M) | (3 << CP0C4_IE) |
> (1 << CP0C4_AE) | (0xfc << CP0C4_KScrExist),
> .CP0_Config5 = MIPS_CONFIG5 | (1 << CP0C5_XNP) | (1 << CP0C5_VP) |
> - (1 << CP0C5_LLB) | (1 << CP0C5_MRP),
> + (1 << CP0C5_LLB) | (1 << CP0C5_MRP) | (3 << CP0C5_GI),
> .CP0_Config5_rw_bitmask = (1 << CP0C5_MSAEn) | (1 << CP0C5_SBRI) |
> (1 << CP0C5_FRE) | (1 << CP0C5_UFE),
> .CP0_LLAddr_rw_bitmask = 0,
> @@ -749,7 +749,7 @@ const mips_def_t mips_defs[] =
> .CP0_Config4 = MIPS_CONFIG4 | (1U << CP0C4_M) | (3 << CP0C4_IE) |
> (1 << CP0C4_AE) | (0xfc << CP0C4_KScrExist),
> .CP0_Config5 = MIPS_CONFIG5 | (1 << CP0C5_XNP) | (1 << CP0C5_VP) |
> - (1 << CP0C5_LLB) | (1 << CP0C5_MRP),
> + (1 << CP0C5_LLB) | (1 << CP0C5_MRP) | (3 << CP0C5_GI),
> .CP0_Config5_rw_bitmask = (1 << CP0C5_MSAEn) | (1 << CP0C5_SBRI) |
> (1 << CP0C5_FRE) | (1 << CP0C5_UFE),
> .CP0_LLAddr_rw_bitmask = 0,
next prev parent reply other threads:[~2023-07-10 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 7:28 [PATCH] target/mips: enable GINVx support for I6400 and I6500 Marcin Nowakowski
2023-07-10 10:42 ` Philippe Mathieu-Daudé
2023-07-10 12:58 ` Jiaxun Yang [this message]
2023-07-10 14:59 ` Philippe Mathieu-Daudé
2023-07-10 19:21 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee19d8a2-733a-23c9-cce9-db8b8dc0e253@flygoat.com \
--to=jiaxun.yang@flygoat.com \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=marcin.nowakowski@fungible.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).