From: Eric Blake <eblake@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>, Kevin Wolf <kwolf@redhat.com>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Qemu-block <qemu-block@nongnu.org>
Subject: Re: [PULL v2] Block layer patches
Date: Fri, 10 Jul 2020 11:05:45 -0500 [thread overview]
Message-ID: <ee21a2d5-0160-f95c-0eef-53d3266041ea@redhat.com> (raw)
In-Reply-To: <CAFEAcA-LwS=MhC9ewXrQht2GzLMa951uGP=8MNGsTPqzEO89GA@mail.gmail.com>
On 7/10/20 10:41 AM, Peter Maydell wrote:
>> qemu-img: Deprecate use of -b without -F (2020-07-09 14:14:55 +0200)
>>
>> ----------------------------------------------------------------
>> Block layer patches:
>>
>> - file-posix: Mitigate file fragmentation with extent size hints
>> - Tighten qemu-img rules on missing backing format
>> - qemu-img map: Don't limit block status request size
>>
>
> iotest 114 fails on FreeBSD and OpenBSD (and probably NetBSD
> but that build hasn't reported back yet): looks like a
> non-portable use of 'truncate' ?
>
> @@ -1,8 +1,11 @@
> QA output created by 114
> -qemu-img: warning: Deprecated use of backing file without explicit
> backing format (detected format of raw)
> -Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=67108864
> backing_file=TEST_DIR/t.IMGFMT.orig
> +truncate: illegal option -- -
> +usage: truncate [-c] -s [+|-|%|/]size[K|k|M|m|G|g|T|t] file ...
> + truncate [-c] -r rfile file ...
> +qemu-img: TEST_DIR/t.IMGFMT: Could not open 'TEST_DIR/t.IMGFMT.orig':
Yep, 'truncate' is not POSIX, but we've been lucky that most of our uses
have been under '_supported_os Linux'; test 272 runs on BSD with
'truncate -s' instead of 'truncate --size'. The fix is obvious; I can
post the followup to squash in if that will help.
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-07-10 16:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 12:17 [PULL v2] Block layer patches Kevin Wolf
2020-07-10 15:41 ` Peter Maydell
2020-07-10 16:05 ` Eric Blake [this message]
2020-07-10 16:14 ` Eric Blake
2020-07-10 16:35 ` [PATCH] fixup! qemu-img: Deprecate use of -b without -F Eric Blake
2020-07-13 11:22 ` [PATCH] fixup! qemu-img: Flush stdout before before potential stderr messages Eric Blake
2020-07-13 11:40 ` [PATCH] fixup! iotests: Specify explicit backing format where sensible Eric Blake
2020-07-13 12:50 ` Kevin 'Max' Wolf
2020-07-13 13:44 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2020-09-08 11:53 [PULL v2] Block layer patches Kevin Wolf
2020-09-09 21:55 ` Peter Maydell
2020-09-09 22:09 ` Eric Blake
2020-09-10 9:13 ` Kevin Wolf
2020-09-10 11:54 ` Max Reitz
2020-09-12 12:27 ` Thomas Huth
2020-09-12 18:38 ` Peter Maydell
2020-09-14 5:36 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee21a2d5-0160-f95c-0eef-53d3266041ea@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).