From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 293C0C433E6 for ; Sat, 29 Aug 2020 18:34:34 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB96B2071B for ; Sat, 29 Aug 2020 18:34:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YOCPK6N+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB96B2071B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:34696 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kC5gP-0005Xy-48 for qemu-devel@archiver.kernel.org; Sat, 29 Aug 2020 14:34:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49828) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kC5fr-00054G-PW for qemu-devel@nongnu.org; Sat, 29 Aug 2020 14:33:59 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]:38749) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kC5fp-0004dt-3C for qemu-devel@nongnu.org; Sat, 29 Aug 2020 14:33:59 -0400 Received: by mail-pj1-x102f.google.com with SMTP id ls14so1006805pjb.3 for ; Sat, 29 Aug 2020 11:33:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=s3VEZQ2WJqqIn2nbv1SGYfMM7G0CRc+I+dQMtfX7Avg=; b=YOCPK6N+iLTusTBrM6fMTHxMd+TwAVdFyp92p2LEX1zngcqqgUllLtWTNMvcSdVd7O 8kM7T9hkW/eyvaUouQSn263rudhZK+tyYFVc10dp1XH7oQgPJ21TwgpfvTPp7qpsh+Gs waRqd/a0yEgSx5+vm/gJqwAUuDLTEXNH6I+hbhLWQatXjY1eoSEOwaItHbinlHqfQzSY C+3NsDsmWkdXHqrG6hxMDj353VchQeMrrvthmMM6imicNFVzCUpp1eDX0OO4LQBqAf5W nMpowIoK+UEN5DZe1LzDIvfqpJNDFY9ibI/9M/35zluxwt7y8vmOr6ZxcIXZVT+D4ZJO MV9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=s3VEZQ2WJqqIn2nbv1SGYfMM7G0CRc+I+dQMtfX7Avg=; b=jUEAekCnFo4yaZyDqIeAthFjw1qH98JttDLsYVS/cxGFWjdBnH0kZyXokjxH42gqUe B2GGVYT9r8W3ezNqO8QJGVIyztgS/tqqTnFtrhOHcoohLCVnNScae/lkewqEli3Ox+L/ P/1NeJtllJkc0q5mVt7LT2+hNURm2LJYFfey770wI0rqzFNM/jvNU0J6kjROGhRhW8Gt 9Ih4fkukFBODvLJJSC3X/paYA3xOwrE7OSsOJm6sYas2iT29L887j0U1pe17qDACsHVD w92bXOSuQ5p17Ot7kDpT9/vuKp76iL7LcESYHtmICTZgLPvHxe20brOUygoDEykfak9g HNEQ== X-Gm-Message-State: AOAM530FtoP3/K1+oUqKy0yfLJYdap7/H4g5VMr+UScTDXOSDVH8H4Au /zccJQuuYGAwvkdqVeg1d7Btbw== X-Google-Smtp-Source: ABdhPJx6qVYm0T+ggTdNDMjoT9rIAtgtFeW3Oh8s+v/zqWHcdDaWUAn4bcoq5FWvVio2drlsTejhTA== X-Received: by 2002:a17:90b:782:: with SMTP id l2mr3873206pjz.108.1598726035248; Sat, 29 Aug 2020 11:33:55 -0700 (PDT) Received: from [192.168.1.11] ([71.212.141.89]) by smtp.gmail.com with ESMTPSA id y3sm2752336pjg.8.2020.08.29.11.33.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 29 Aug 2020 11:33:54 -0700 (PDT) Subject: Re: [RFC v4 19/70] target/riscv: rvv-1.0: index load and store instructions To: frank.chang@sifive.com, qemu-devel@nongnu.org, qemu-riscv@nongnu.org References: <20200817084955.28793-1-frank.chang@sifive.com> <20200817084955.28793-20-frank.chang@sifive.com> From: Richard Henderson Message-ID: Date: Sat, 29 Aug 2020 11:33:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20200817084955.28793-20-frank.chang@sifive.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102f.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -28 X-Spam_score: -2.9 X-Spam_bar: -- X-Spam_report: (-2.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.809, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/17/20 1:49 AM, frank.chang@sifive.com wrote: > +static bool vext_check_st_index(DisasContext *s, int vd, int vs2, int nf, > + uint8_t eew) > { > - return !s->vill; > + uint8_t lmul_r = s->lmul < 0 ? 0 : s->lmul; > + int8_t emul = ctzl(eew) - (s->sew + 3) + s->lmul; > + return (emul >= -3 && emul <= 3) && > + require_align(vs2, 1 << emul) && > + require_align(vd, 1 << s->lmul) && > + ((nf << lmul_r) <= (NVPR / 4) && > + (vd + (nf << lmul_r)) <= NVPR); > +} Same comments wrt EEW as the last patch. It wouldn't hurt to extract something like static bool require_nf(int vd, int nf, int lmul) { int size = nf << MAX(lmul, 0); return size <= 8 && vd + size <= 32; } in the previous patch as well. r~