From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiY2d-0005iU-EO for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:31 -0500 Received: from [199.232.76.173] (port=34666 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiY2c-0005hQ-W5 for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:31 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiY2c-0008RP-6h for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:30 -0500 Received: from mail-bw0-f218.google.com ([209.85.218.218]:41106) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiY2b-0008Qv-PN for qemu-devel@nongnu.org; Fri, 19 Feb 2010 13:57:30 -0500 Received: by bwz10 with SMTP id 10so354260bwz.2 for ; Fri, 19 Feb 2010 10:57:28 -0800 (PST) MIME-Version: 1.0 Date: Fri, 19 Feb 2010 18:57:27 +0000 Message-ID: From: Jay Foad Content-Type: text/plain; charset=ISO-8859-1 Subject: [Qemu-devel] [PATCH] tcg: fix assertion with --enable-debug List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org After configuring with --enable-debug on Linux/x86, I get: foad@foad-ubuntu:~/qemu/objdir-git$ qemu-alpha /dev/null qemu-alpha: /home/foad/git/qemu/tcg/tcg.c:1055: tcg_add_target_add_op_defs: Assertion `tcg_op_defs[op].used' failed. Aborted (and the same for all other targets). The qemu_ld32s op appears to be unused on 32-bit hosts. Is it OK to just remove it? Signed-off-by: Jay Foad --- tcg/tcg-opc.h | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/tcg/tcg-opc.h b/tcg/tcg-opc.h index 89db3b4..838f1f4 100644 --- a/tcg/tcg-opc.h +++ b/tcg/tcg-opc.h @@ -224,11 +224,6 @@ DEF2(qemu_ld32u, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) DEF2(qemu_ld32u, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) #endif #if TARGET_LONG_BITS == 32 -DEF2(qemu_ld32s, 1, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) -#else -DEF2(qemu_ld32s, 1, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) -#endif -#if TARGET_LONG_BITS == 32 DEF2(qemu_ld64, 2, 1, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS) #else DEF2(qemu_ld64, 2, 2, 1, TCG_OPF_CALL_CLOBBER | TCG_OPF_SIDE_EFFECTS)