From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D0F2C433EF for ; Fri, 1 Oct 2021 16:37:06 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D3A906109E for ; Fri, 1 Oct 2021 16:37:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D3A906109E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mWLWy-00055g-Tg for qemu-devel@archiver.kernel.org; Fri, 01 Oct 2021 12:37:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46028) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mWLUW-0003ju-QV for qemu-devel@nongnu.org; Fri, 01 Oct 2021 12:34:32 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:36629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mWLUV-0006k8-9t for qemu-devel@nongnu.org; Fri, 01 Oct 2021 12:34:32 -0400 Received: by mail-qk1-x732.google.com with SMTP id p4so9709272qki.3 for ; Fri, 01 Oct 2021 09:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=fXM9N5tnq2moWBT/kcjda9tO0kiSuwnQK43uWjgag+Y=; b=YHo54dhrrl5J8RQmeqaEu7SM7A+sJ0iK6tSlQAebn9PQLnD2rQU25aD2D3TBveseZ4 3w4ok9C//unX6lPdbUeC0zeATDd4YegpwGNAzmui8ewwlSUY5nEyX3eEXgA7arnz5HgQ 32afKpLfQRwABvGluv7zCiGwfvL89GcLtKIh5kWqHHG++THORaLK3lhfsRq1bodzsMfk zJ/0mLKIrNqwdz4gLY90TySA0grkvGdyawE98ekPJ/L32PN/hOsoQaaEeDO5R3JiuFdX ium+Jk4y8vuQrkl9Tk5l8NTnle3OUhwdn3x0UeoAG7L+c6ku3pPajHit4VPCEvLtC04y h95Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fXM9N5tnq2moWBT/kcjda9tO0kiSuwnQK43uWjgag+Y=; b=ymkuj4mBvY7iXG4Y/25M9bCi72TLHhp2ZcOxphQgeA8etDZhDm/D542Ggw+8vW0m0c 6VFhTDOTIJ8N/2CdDaCYP07PCvp5EjOE0MjJiq0ad//3dVOve+QnzxzxHFafFsyLJyo1 CaQCHXfMR/y55Cx9v1gVRTzY9a4CchysqVJEXdWgFhCaekgVOBaPwyxfwk8M51E1mztB Sz/LaJx12Bu6t0lyFj+JS2JsIw5Xiaz9TJpshS1XpHHYaBo0C5/DlD1qYFzcRLDTO13d Z4tFkHEZWwOqEUJPdW2YrLUUMiI+8umuI+asD5JrYJqvg5L3f4hN6XnSBPEItDWAuS8Q ry3Q== X-Gm-Message-State: AOAM533ZcIoJ/7ofD1IZ0byorN577Qxwau2imAJqAEfWhoViILwg6ibo VZ9Gm8ewF0aSCfpzz0ViZQegeyTMxUkRXg== X-Google-Smtp-Source: ABdhPJxsCGVxou9ZkE414UmTvRwp/mox7taCdV3BWgjP+kbAdNdRH4xgJmHFAFz5jf0x5EAcTr74Fg== X-Received: by 2002:a37:9144:: with SMTP id t65mr10507841qkd.170.1633106070276; Fri, 01 Oct 2021 09:34:30 -0700 (PDT) Received: from [192.168.3.43] (c-67-174-166-185.hsd1.ga.comcast.net. [67.174.166.185]) by smtp.gmail.com with ESMTPSA id b20sm3481676qtt.2.2021.10.01.09.34.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Oct 2021 09:34:29 -0700 (PDT) Subject: Re: [PATCH 3/3] hw/intc/arm_gicv3: Support multiple redistributor regions To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20210930150842.3810-1-peter.maydell@linaro.org> <20210930150842.3810-4-peter.maydell@linaro.org> From: Richard Henderson Message-ID: Date: Fri, 1 Oct 2021 12:34:27 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210930150842.3810-4-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=richard.henderson@linaro.org; helo=mail-qk1-x732.google.com X-Spam_score_int: -31 X-Spam_score: -3.2 X-Spam_bar: --- X-Spam_report: (-3.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-1.127, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/30/21 11:08 AM, Peter Maydell wrote: > Our GICv3 QOM interface includes an array property > redist-region-count which allows board models to specify that the > registributor registers are not in a single contiguous range, but > split into multiple pieces. We implemented this for KVM, but > currently the TCG GICv3 model insists that there is only one region. > You can see the limit being hit with a setup like: > qemu-system-aarch64 -machine virt,gic-version=3 -smp 124 > > Add support for split regions to the TCG GICv3. To do this we switch > from allocating a simple array of MemoryRegions to an array of > GICv3RedistRegion structs so that we can use the GICv3RedistRegion as > the opaque pointer in the MemoryRegion read/write callbacks. Each > GICv3RedistRegion contains the MemoryRegion, a backpointer allowing > the read/write callback to get hold of the GICv3State, and an index > which allows us to calculate which CPU's redistributor is being > accessed. > > Note that arm_gicv3_kvm always passes in NULL as the ops argument > to gicv3_init_irqs_and_mmio(), so the only MemoryRegion read/write > callbacks we need to update to handle this new scheme are the > gicv3_redist_read/write functions used by the emulated GICv3. > > Signed-off-by: Peter Maydell > --- Reviewed-by: Richard Henderson r~