From: Paolo Bonzini <pbonzini@redhat.com>
To: Thomas Huth <thuth@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>,
qemu-devel@nongnu.org
Cc: jsnow@redhat.com, f4bug@amsat.org
Subject: Re: [Qemu-devel] regression: sata cdrom boot broken
Date: Thu, 21 Jun 2018 13:22:18 +0200 [thread overview]
Message-ID: <ee3462a2-bad7-3b2f-e218-356529163663@redhat.com> (raw)
In-Reply-To: <ce257b1b-4d04-9e76-2ded-730b2a410f91@redhat.com>
On 20/06/2018 20:15, Thomas Huth wrote:
> On 20.06.2018 13:07, Gerd Hoffmann wrote:
>> Hi,
>>
>> $subject says all. Noticed while testing the upcoming seabios update.
>> Reproducer:
>>
>> qemu-system-x86_64 -M q35 -m 4G -cdrom Fedora-Workstation-Live-x86_64-28-1.1.iso
>
> Once this has been fixed, please add a regression test to tests/cdrom-test.c
> for this, so that it can not happen so easily again. A line like this
> should do the job:
>
> qtest_add_data_func("cdrom/boot/q35", "-M q35 -cdrom ", test_cdboot);
Nice! The patch I've sent fixes tests/ahci-test.c to match what the
code now does, but cdrom-test.c is also good.
Thanks,
Paolo
prev parent reply other threads:[~2018-06-21 11:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-20 11:07 [Qemu-devel] regression: sata cdrom boot broken Gerd Hoffmann
2018-06-20 12:18 ` Paolo Bonzini
2018-06-20 20:28 ` John Snow
2018-06-21 10:50 ` Paolo Bonzini
2018-06-20 18:15 ` Thomas Huth
2018-06-21 11:22 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee3462a2-bad7-3b2f-e218-356529163663@redhat.com \
--to=pbonzini@redhat.com \
--cc=f4bug@amsat.org \
--cc=jsnow@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).