From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36762) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVxfV-00078e-Ie for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:22:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVxfR-0005aj-Jo for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:22:25 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:36704 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fVxfR-0005af-Do for qemu-devel@nongnu.org; Thu, 21 Jun 2018 07:22:21 -0400 References: <20180620110741.gdywesuqbyhjs4hd@sirius.home.kraxel.org> From: Paolo Bonzini Message-ID: Date: Thu, 21 Jun 2018 13:22:18 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] regression: sata cdrom boot broken List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thomas Huth , Gerd Hoffmann , qemu-devel@nongnu.org Cc: jsnow@redhat.com, f4bug@amsat.org On 20/06/2018 20:15, Thomas Huth wrote: > On 20.06.2018 13:07, Gerd Hoffmann wrote: >> Hi, >> >> $subject says all. Noticed while testing the upcoming seabios update. >> Reproducer: >> >> qemu-system-x86_64 -M q35 -m 4G -cdrom Fedora-Workstation-Live-x86_64-28-1.1.iso > > Once this has been fixed, please add a regression test to tests/cdrom-test.c > for this, so that it can not happen so easily again. A line like this > should do the job: > > qtest_add_data_func("cdrom/boot/q35", "-M q35 -cdrom ", test_cdboot); Nice! The patch I've sent fixes tests/ahci-test.c to match what the code now does, but cdrom-test.c is also good. Thanks, Paolo