qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <laurent@vivier.eu>
To: Thomas Huth <thuth@redhat.com>, qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Magnus Damm <magnus.damm@gmail.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>
Subject: Re: [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition
Date: Thu, 31 Mar 2022 18:22:29 +0200	[thread overview]
Message-ID: <ee4c5717-37fb-6053-497d-06925eed8fcc@vivier.eu> (raw)
In-Reply-To: <20220330134302.979686-1-thuth@redhat.com>

Le 30/03/2022 à 15:43, Thomas Huth a écrit :
> Seen while compiling on Alpine:
> 
>   In file included from ../linux-user/strace.c:17:
>   In file included from ../linux-user/qemu.h:11:
>   In file included from ../linux-user/syscall_defs.h:1247:
>   ../linux-user/sh4/termbits.h:276:10: warning: 'TIOCSER_TEMT' macro redefined
>    [-Wmacro-redefined]
>   # define TIOCSER_TEMT    0x01   /* Transmitter physically empty */
>            ^
>   /usr/include/sys/ioctl.h:50:9: note: previous definition is here
>   #define TIOCSER_TEMT 1
>           ^
>   1 warning generated.
> 
> Add the TARGET_ prefix here, too, like we do it on the other architectures.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
>   linux-user/sh4/termbits.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)

Thomas,

do you think it can wait 7.1?

Thanks,
Laurent


  parent reply	other threads:[~2022-03-31 16:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-30 13:43 [PATCH] linux-user/sh4/termbits: Silence warning about TIOCSER_TEMT double definition Thomas Huth
2022-03-30 13:54 ` Richard Henderson
2022-03-30 14:13 ` Philippe Mathieu-Daudé
2022-03-30 14:37 ` Laurent Vivier
2022-03-31 13:25 ` Yoshinori Sato
2022-03-31 16:22 ` Laurent Vivier [this message]
2022-03-31 17:31   ` Richard Henderson
2022-04-01  6:13     ` Thomas Huth
2022-03-31 19:28 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee4c5717-37fb-6053-497d-06925eed8fcc@vivier.eu \
    --to=laurent@vivier.eu \
    --cc=magnus.damm@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=thuth@redhat.com \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).