From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77F2EC31E5B for ; Mon, 17 Jun 2019 19:25:16 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3F12E2085A for ; Mon, 17 Jun 2019 19:25:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Kql0QhwS" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3F12E2085A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcxFi-0003A7-Pi for qemu-devel@archiver.kernel.org; Mon, 17 Jun 2019 15:25:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44303) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcwub-0007zJ-UO for qemu-devel@nongnu.org; Mon, 17 Jun 2019 15:03:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcwua-0002jd-Ve for qemu-devel@nongnu.org; Mon, 17 Jun 2019 15:03:25 -0400 Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]:43518) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcwua-0002hN-LL for qemu-devel@nongnu.org; Mon, 17 Jun 2019 15:03:24 -0400 Received: by mail-pf1-x444.google.com with SMTP id i189so6168328pfg.10 for ; Mon, 17 Jun 2019 12:03:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=iZHzBIb+2T7t0rnvFVP9Ixb3KVylrfKNn21WvVXuJpw=; b=Kql0QhwS5l8zAR9vPZI7vrtQq1OwB8FP8vycgIHYqabKVPPUGprCKXDCBaDejKMYq+ +FAId42zOBwxMYPIV33lY4urr4ox0XYjzi6ZqPB3yAQsC6x0Fmaimnzsi24S+SQrhwOU 3clk7KTmJmgKXKv1cWYHgpURFmy3NMaSwBoRWad6znW/SzNWumOFyENtgR0d7WbaRmlP Ic+UlLH+PeeoSj3+54tIMfgpT+L7NG0gTTzBDgtwTZ75PjVLWrYlPUeeK0X2owhenxGx u9pi79gDW+vdUfbmkh/Wp2hIg6pnyWWvoY46AWoSZC+dFHyOCGDayUwYVvNlsnAl2Hpv 2KSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iZHzBIb+2T7t0rnvFVP9Ixb3KVylrfKNn21WvVXuJpw=; b=O+mJXeTtelPgZo8mvQwAoQj0bnOIQbc/a/gb3w4HGKwN9m1lUlO007RxOvQE+YfHCz VO6HcH2cKqk22zJLm6iO+iUOZ4JeDV+kp/tKHEpu3sXislaZqwK4wQktmgpUM1xtwUU+ fFtXgklB4cn1yjtvu/0x6K6nUon/rbSkJIn83zjPvZFE/2DNsi82rULFjAMr2j8SJYkf taA6egifBIOeaLv+Lhz5axWSacaG1LytZn0ypSSlaVgaCd1m7EFuMYi1Nuugrl/m8tpH dfB/zeP7VxGMUZ+T5hcWbKc6HyUp6M6tbGh0jJuPMlQScuAjcxGDZSo4dWG66BWKpM0o S1Ew== X-Gm-Message-State: APjAAAUgU1Ue8WdLZZMQjXSIX+iqCMxxYW5H41Xi3g95dX4Q4wT4zpiz kW3slAsQAAvT5F9kMxuSt/Qr+GlzEyo= X-Google-Smtp-Source: APXvYqyNDgz9JJ/C7T6ZwRR5SPbfhFATm8W2mur1iqN7gba+ZtgPzBxfuqo+dC/9F24XE2PHK7xgJg== X-Received: by 2002:aa7:8dd2:: with SMTP id j18mr45558585pfr.88.1560798183183; Mon, 17 Jun 2019 12:03:03 -0700 (PDT) Received: from [192.168.1.11] (97-113-2-33.tukw.qwest.net. [97.113.2.33]) by smtp.gmail.com with ESMTPSA id 128sm13061319pff.16.2019.06.17.12.03.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 12:03:02 -0700 (PDT) To: Peter Maydell , qemu-arm@nongnu.org, qemu-devel@nongnu.org References: <20190617160130.3207-1-peter.maydell@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: Date: Mon, 17 Jun 2019 12:03:00 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190617160130.3207-1-peter.maydell@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::444 Subject: Re: [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/17/19 9:01 AM, Peter Maydell wrote: > In commit 1120827fa182f0e7622 we accidentally put the > "UNDEF unless FPU has double-precision support" check in > the single-precision VFM function. Put it in the dp > function where it belongs. > > Signed-off-by: Peter Maydell > --- > I just merged the pullreq with 1120827fa182f0e7622 an hour > ago and then I spotted this bug in it... > > target/arm/translate-vfp.inc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Oops. Reviewed-by: Richard Henderson r~