* [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp
@ 2019-06-17 16:01 Peter Maydell
2019-06-17 19:03 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2019-06-17 16:01 UTC (permalink / raw)
To: qemu-arm, qemu-devel; +Cc: Richard Henderson
In commit 1120827fa182f0e7622 we accidentally put the
"UNDEF unless FPU has double-precision support" check in
the single-precision VFM function. Put it in the dp
function where it belongs.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I just merged the pullreq with 1120827fa182f0e7622 an hour
ago and then I spotted this bug in it...
target/arm/translate-vfp.inc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/target/arm/translate-vfp.inc.c b/target/arm/translate-vfp.inc.c
index 348173d6026..deaddb04421 100644
--- a/target/arm/translate-vfp.inc.c
+++ b/target/arm/translate-vfp.inc.c
@@ -1771,10 +1771,6 @@ static bool trans_VFM_sp(DisasContext *s, arg_VFM_sp *a)
return false;
}
- if (!dc_isar_feature(aa32_fpdp, s)) {
- return false;
- }
-
if (!vfp_access_check(s)) {
return true;
}
@@ -1838,6 +1834,10 @@ static bool trans_VFM_dp(DisasContext *s, arg_VFM_dp *a)
return false;
}
+ if (!dc_isar_feature(aa32_fpdp, s)) {
+ return false;
+ }
+
if (!vfp_access_check(s)) {
return true;
}
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp
2019-06-17 16:01 [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp Peter Maydell
@ 2019-06-17 19:03 ` Richard Henderson
2019-06-18 14:46 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2019-06-17 19:03 UTC (permalink / raw)
To: Peter Maydell, qemu-arm, qemu-devel
On 6/17/19 9:01 AM, Peter Maydell wrote:
> In commit 1120827fa182f0e7622 we accidentally put the
> "UNDEF unless FPU has double-precision support" check in
> the single-precision VFM function. Put it in the dp
> function where it belongs.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I just merged the pullreq with 1120827fa182f0e7622 an hour
> ago and then I spotted this bug in it...
>
> target/arm/translate-vfp.inc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Oops.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp
2019-06-17 19:03 ` Richard Henderson
@ 2019-06-18 14:46 ` Peter Maydell
0 siblings, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2019-06-18 14:46 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-arm, QEMU Developers
On Mon, 17 Jun 2019 at 20:03, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> On 6/17/19 9:01 AM, Peter Maydell wrote:
> > In commit 1120827fa182f0e7622 we accidentally put the
> > "UNDEF unless FPU has double-precision support" check in
> > the single-precision VFM function. Put it in the dp
> > function where it belongs.
> >
> > Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> > ---
> > I just merged the pullreq with 1120827fa182f0e7622 an hour
> > ago and then I spotted this bug in it...
> >
> > target/arm/translate-vfp.inc.c | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Oops.
>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Applied to master, given it was a silly regression.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-18 16:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-17 16:01 [Qemu-devel] [PATCH] target/arm: Check for dp support for dp VFM, not sp Peter Maydell
2019-06-17 19:03 ` Richard Henderson
2019-06-18 14:46 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).