From: Laurent Vivier <laurent@vivier.eu>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: Fredrik Noring <noring@nocrew.org>,
Richard Henderson <richard.henderson@linaro.org>,
Aurelien Jarno <aurelien@aurel32.net>,
"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls
Date: Thu, 17 Dec 2020 21:14:54 +0100 [thread overview]
Message-ID: <ee6c277f-45ff-16f0-970c-100d355abd6b@vivier.eu> (raw)
In-Reply-To: <e1e6feeb-3bb3-d628-a87f-3696e9809d01@amsat.org>
Le 17/12/2020 à 17:10, Philippe Mathieu-Daudé a écrit :
> On 12/17/20 11:40 AM, Laurent Vivier wrote:
>> Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit :
>>> o32 ABI syscalls start at offset 4000.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> linux-user/mips64/syscall_nr.h | 5 ++++-
>>> 1 file changed, 4 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/linux-user/mips64/syscall_nr.h b/linux-user/mips64/syscall_nr.h
>>> index 672f2fa51cb..6579421fa63 100644
>>> --- a/linux-user/mips64/syscall_nr.h
>>> +++ b/linux-user/mips64/syscall_nr.h
>>> @@ -1,4 +1,7 @@
>>> -#ifdef TARGET_ABI_MIPSN32
>>> +#if defined(TARGET_ABI_MIPSO32)
>>> +#define TARGET_SYSCALL_OFFSET 4000
>>
>> The value of the offset is hardcoded in linux-user/mips/meson.build, so either you remove
>> TARGET_SYSCALL_OFFSET here or you update meson.build to use it.
>
> I don't understand what this Meson rule does, as this
> doesn't work without this patch...
Yes, you're right, this is hardcoded in mips directory, not in mips64 directory.
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
next prev parent reply other threads:[~2020-12-17 20:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 16:17 [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs Philippe Mathieu-Daudé
2020-11-19 16:17 ` [PATCH 1/4] linux-user/mips64: Restore setup_frame() for o32 ABI Philippe Mathieu-Daudé
2020-11-19 23:07 ` Richard Henderson
2020-12-17 10:18 ` Laurent Vivier
2021-02-11 21:33 ` Laurent Vivier
2020-11-19 16:17 ` [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls Philippe Mathieu-Daudé
2020-11-19 23:08 ` Richard Henderson
2020-11-19 23:09 ` Richard Henderson
2020-12-17 10:40 ` Laurent Vivier
2020-12-17 16:10 ` Philippe Mathieu-Daudé
2020-12-17 17:20 ` Fredrik Noring
2020-12-17 20:14 ` Laurent Vivier [this message]
2021-02-11 21:33 ` Laurent Vivier
2020-11-19 16:17 ` [PATCH 3/4] default-configs: Support o32 ABI with 64-bit MIPS CPUs Philippe Mathieu-Daudé
2020-11-19 16:45 ` Maciej W. Rozycki
2020-11-19 17:13 ` Philippe Mathieu-Daudé
2020-12-12 8:29 ` Fredrik Noring
2020-12-12 17:03 ` Fredrik Noring
2020-11-19 16:17 ` [PATCH 4/4] RFC qemu-binfmt-conf.sh: Add MIPS64 o32 ABI Philippe Mathieu-Daudé
2020-11-19 23:14 ` Richard Henderson
2020-11-19 16:27 ` [PATCH 0/4] linux-user: Support o32 ABI with 64-bit MIPS CPUs no-reply
2020-12-13 15:14 ` Philippe Mathieu-Daudé
2021-02-09 18:31 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee6c277f-45ff-16f0-970c-100d355abd6b@vivier.eu \
--to=laurent@vivier.eu \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=macro@linux-mips.org \
--cc=noring@nocrew.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).