From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEA61C4361B for ; Thu, 17 Dec 2020 20:17:33 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 02CD1239FE for ; Thu, 17 Dec 2020 20:17:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 02CD1239FE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=vivier.eu Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:35118 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kpziN-0005VE-Ks for qemu-devel@archiver.kernel.org; Thu, 17 Dec 2020 15:17:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53100) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpzgL-0004Lc-Gb for qemu-devel@nongnu.org; Thu, 17 Dec 2020 15:15:25 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:40645) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kpzgE-0004Wf-I1 for qemu-devel@nongnu.org; Thu, 17 Dec 2020 15:15:25 -0500 Received: from [192.168.100.1] ([82.252.144.198]) by mrelayeu.kundenserver.de (mreue012 [213.165.67.103]) with ESMTPSA (Nemesis) id 1MTw02-1kggGg1FoI-00R49C; Thu, 17 Dec 2020 21:14:56 +0100 Subject: Re: [PATCH 2/4] linux-user/mips64: Support o32 ABI syscalls To: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , qemu-devel@nongnu.org References: <20201119161710.1985083-1-f4bug@amsat.org> <20201119161710.1985083-3-f4bug@amsat.org> From: Laurent Vivier Message-ID: Date: Thu, 17 Dec 2020 21:14:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:NScEaSIEsbi6feE3r3Y9lhpkHpf+uHnbDWlBrHXZEJv4K7LVG1D JNSruIMXJV7BtBXyzQDxXtoR03QIP+peU+mHeVOZdKUCOZPsxx6Mbj7QH8UBRqxfc8rMose aAE2KMReaoKwGf51NnP8blmgLi26haPaZt/tQUEqA2yWapM6L8SmY2J/9WXgDGbQmejrCS5 eLwBS9jjn+5JidVk/xAWA== X-UI-Out-Filterresults: notjunk:1;V03:K0:A6nAADJ5Fbk=:ZN7qWU8avQS+NKvj4FVLkz I62bABTwGg1wDKI2jNjwO+G1CVQOjDgdjXwm8eCgbW3OMngfIEE5CKwucpdFOIypzhkJQcrr7 3xVfCT5lOtRhXsmGDm34ZHKsnVWPd/r5RXbncxgSqU1U/UqmEi5v/Eye6fCtHasQQcw5q9C+U LZwdWcOReVDGdZ9VW2q9eHnytMxyd1B/3lqDnmr4kcGG0J1fORBGBgJzXjANlIB3SYO5CDSTp oKAbtGgW0wwGjsrFN/iB3KkZ+9ZJHBiofVQh81hL9k5S1kp7NHV95G1ouvRHUVRtBuEw3iiI+ VNonM0XQNzw8nN4t2AxKfGFcC52lZ9YRKt4Eq00QoOyO+4PfS986K5wPsKCooDXkHyxQrpaWx UmC5B7Fth7+K6zjJ1xLYBJY9oVE6PCwduViz+/b7EbGmOYTxA1/SjoF0EHwyC9TwpkNRjR+XI Du2M0X9fgA== Received-SPF: none client-ip=212.227.126.187; envelope-from=laurent@vivier.eu; helo=mout.kundenserver.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fredrik Noring , Richard Henderson , Aurelien Jarno , "Maciej W. Rozycki" Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Le 17/12/2020 à 17:10, Philippe Mathieu-Daudé a écrit : > On 12/17/20 11:40 AM, Laurent Vivier wrote: >> Le 19/11/2020 à 17:17, Philippe Mathieu-Daudé a écrit : >>> o32 ABI syscalls start at offset 4000. >>> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> linux-user/mips64/syscall_nr.h | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/linux-user/mips64/syscall_nr.h b/linux-user/mips64/syscall_nr.h >>> index 672f2fa51cb..6579421fa63 100644 >>> --- a/linux-user/mips64/syscall_nr.h >>> +++ b/linux-user/mips64/syscall_nr.h >>> @@ -1,4 +1,7 @@ >>> -#ifdef TARGET_ABI_MIPSN32 >>> +#if defined(TARGET_ABI_MIPSO32) >>> +#define TARGET_SYSCALL_OFFSET 4000 >> >> The value of the offset is hardcoded in linux-user/mips/meson.build, so either you remove >> TARGET_SYSCALL_OFFSET here or you update meson.build to use it. > > I don't understand what this Meson rule does, as this > doesn't work without this patch... Yes, you're right, this is hardcoded in mips directory, not in mips64 directory. Reviewed-by: Laurent Vivier