From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44195) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dZoUB-0008Mq-4V for qemu-devel@nongnu.org; Mon, 24 Jul 2017 21:18:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dZoUA-0003sz-1r for qemu-devel@nongnu.org; Mon, 24 Jul 2017 21:18:07 -0400 References: <7fb8c9ff25d183cf7c0f729a90ee4f59c0632d64.1497602554.git.maozy.fnst@cn.fujitsu.com> <38f43362-e3a3-44ab-9c29-d04b4c825085@redhat.com> From: Mao Zhongyi Message-ID: Date: Tue, 25 Jul 2017 09:16:59 +0800 MIME-Version: 1.0 In-Reply-To: <38f43362-e3a3-44ab-9c29-d04b4c825085@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [Qemu-block] [PATCH v3] util: remove the obsolete non-blocking connect List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow , qemu-devel@nongnu.org Cc: kwolf@redhat.com, berrange@redhat.com, qemu-block@nongnu.org, quintela@redhat.com, mitake.hitoshi@lab.ntt.co.jp, Cao jin , mreitz@redhat.com, sheepdog@lists.wpkg.org, kraxel@redhat.com, pbonzini@redhat.com, famz@redhat.com, namei.unix@gmail.com On 07/25/2017 06:07 AM, John Snow wrote: > This was posted over a month ago with two R-Bs, did it get merged or dropped? > > --js Not yet, I hope that it will. Thanks, Mao > > On 06/16/2017 04:54 AM, Mao Zhongyi wrote: >> From: Cao jin >> >> The non-blocking connect mechanism is obsolete, and it doesn't >> work well in inet connection, because it will call getaddrinfo >> first and getaddrinfo will blocks on DNS lookups. Since commit >> e65c67e4 & d984464e, the non-blocking connect of migration goes >> through QIOChannel in a different manner(using a thread), and >> nobody use this old non-blocking connect anymore. >> >> Any newly written code which needs a non-blocking connect should >> use the QIOChannel code, so we can drop NonBlockingConnectHandler >> as a concept entirely. >> >> Suggested-by: Daniel P. Berrange >> Signed-off-by: Cao jin >> Signed-off-by: Mao Zhongyi >> Reviewed-by: Juan Quintela >> Reviewed-by: Daniel P. Berrange >> --- >> v3: >> 1. fix the mistake that adds a unmodified file '--help' [Fam Zheng] >> >> v2: >> 1. block/ssh.c is not compiled in v1 which leads to no error >> reported when I run make & make check, although I make a >> mistake in block/ssh.c, because the package libssh2-devel >> missed in my system. Now fixed it. >> 2. Write the prototype in a single line. [Juan Quintela] >> >> Because it's a minor change, so still add the r-b. >> >> v1: >> This patch was reviewed by Daniel about a years ago, but it has never >> been merged just since socket_connect() called by net_socket_connect_init() >> where NonBlockingConnectHandler was passed to socket_connect(). it's broken. >> >> Now this problem was worked around by Daniel's patch(commit 6701e551 'Revert >> "Change net/socket.c to use socket_*() functions" again'). Therefore, resend >> it, of course, part of related code has changed over the years, so changed >> the patch accordingly. >> >> The reviewed patch listed on: >> https://lists.gnu.org/archive/html/qemu-devel/2016-07/msg06373.html >> >> block/sheepdog.c | 2 +- >> block/ssh.c | 2 +- >> include/qemu/sockets.h | 12 +-- >> io/channel-socket.c | 2 +- >> util/qemu-sockets.c | 205 ++++++------------------------------------------- >> 5 files changed, 28 insertions(+), 195 deletions(-) >> > > [snip] > > >