Re: [PATCH] kvm/kvm-all: declare kvm_park_vcpu static and make it local to kvm-all.c

[Richard Henderson <richard.henderson@linaro.org>]

On 8/15/25 15:30, Ani Sinha wrote:
> kvm_park_vcpu() is only used in kvm-all.c. Declare it static, remove it from
> common header file and make it local to kvm-all.c
> 
> Signed-off-by: Ani Sinha <anisinha@redhat.com>
> ---
>   accel/kvm/kvm-all.c  | 3 ++-
>   include/system/kvm.h | 8 --------
>   2 files changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/accel/kvm/kvm-all.c b/accel/kvm/kvm-all.c
> index 890d5ea9f8..41cf606ca8 100644
> --- a/accel/kvm/kvm-all.c
> +++ b/accel/kvm/kvm-all.c
> @@ -141,6 +141,7 @@ static QemuMutex kml_slots_lock;
>   #define kvm_slots_unlock()  qemu_mutex_unlock(&kml_slots_lock)
>   
>   static void kvm_slot_init_dirty_bitmap(KVMSlot *mem);
> +static void kvm_park_vcpu(CPUState *cpu);
>   

No need for this, since the definition precedes all uses.
You can also unexport kvm_unpark_vcpu.


r~