From: Jason Wang <jasowang@redhat.com>
To: P J P <ppandit@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>
Cc: "Li Qiang" <liq3ea@gmail.com>,
"Daniel P . Berrangé" <berrange@redhat.com>,
"Prasad J Pandit" <pjp@fedoraproject.org>
Subject: Re: [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ
Date: Fri, 26 Jul 2019 18:26:08 +0800 [thread overview]
Message-ID: <ee8f8b24-bc60-293b-e458-f598361612ea@redhat.com> (raw)
In-Reply-To: <20190723104754.29324-1-ppandit@redhat.com>
On 2019/7/23 下午6:47, P J P wrote:
> From: Prasad J Pandit <pjp@fedoraproject.org>
>
> Hello,
>
> Linux net_deivce defines network interface name to be of IFNAMSIZE(=16)
> bytes, including the terminating null('\0') byte.
>
> Qemu tap deivce, while invoking 'qemu-bridge-helper' tool to set up the
> network bridge interface, supplies bridge name of 16 characters, thus
> allowing to create an ACL bypass scenario.
>
> This patch series attempts to fix it. It also updates bridge helper
> invocation routine 'net_bridge_run_helper' to avoid snprintf() calls.
>
> Thank you.
> --
> Prasad J Pandit (3):
> qemu-bridge-helper: restrict interface name to IFNAMSIZ
> qemu-bridge-helper: move repeating code in parse_acl_file
> net: tap: replace snprintf with g_strdup_printf calls
>
> net/tap.c | 19 +++++++++++--------
> qemu-bridge-helper.c | 24 +++++++++++++++++-------
> 2 files changed, 28 insertions(+), 15 deletions(-)
>
Applied.
Thanks
prev parent reply other threads:[~2019-07-26 10:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 10:47 [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ P J P
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 1/3] qemu-bridge-helper: restrict " P J P
2019-07-23 13:10 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 2/3] qemu-bridge-helper: move repeating code in parse_acl_file P J P
2019-07-23 13:00 ` Stefan Hajnoczi
2019-07-23 13:12 ` Daniel P. Berrangé
2019-07-23 15:07 ` Li Qiang
2019-07-23 10:47 ` [Qemu-devel] [PATCH v4 3/3] net: tap: replace snprintf with g_strdup_printf calls P J P
2019-07-23 13:03 ` Stefan Hajnoczi
2019-07-23 15:43 ` Li Qiang
2019-07-24 5:48 ` P J P
2019-07-29 15:04 ` Stefan Hajnoczi
2019-07-31 4:58 ` Jason Wang
2019-07-31 6:42 ` P J P
2019-07-31 6:59 ` Jason Wang
2019-07-31 9:23 ` P J P
2019-07-23 13:13 ` Daniel P. Berrangé
2019-07-23 17:44 ` [Qemu-devel] [PATCH v4 0/3] restrict bridge interface name to IFNAMSIZ no-reply
2019-07-25 4:01 ` Jason Wang
2019-07-25 10:20 ` P J P
2019-07-26 10:26 ` Jason Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8f8b24-bc60-293b-e458-f598361612ea@redhat.com \
--to=jasowang@redhat.com \
--cc=berrange@redhat.com \
--cc=liq3ea@gmail.com \
--cc=pjp@fedoraproject.org \
--cc=ppandit@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).