From: Thomas Huth <thuth@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>,
BALATON Zoltan <balaton@eik.bme.hu>
Cc: QEMU Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] Stair step trace output since 12fb0ac05
Date: Thu, 7 Jun 2018 13:14:43 +0200 [thread overview]
Message-ID: <ee8ff819-2344-bbaf-fa2e-e0c0a9d0f385@redhat.com> (raw)
In-Reply-To: <CAFEAcA8b6ziWp2ZAhyG2pY2V6EVzBNodv4ZDxFKc8hdV1=oZTw@mail.gmail.com>
On 06.06.2018 20:33, Peter Maydell wrote:
> On 6 June 2018 at 18:15, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>> Hello,
>>
>> Since 12fb0ac05 (char: Remove unwanted crlf conversion) trace output is
>> printed in stair steps when using -trace and -serial stdio together. E.g.
>> $ qemu-system-i386 -trace 'pci*' -serial stdio
>
> I had a feeling that we were going to find that there were
> situations where we really wanted to retain the crlf
> processing...
I think the problem is that we've turned it on in char-stdio.c, too.
char-serial.c should be sufficient.
Is someone volunteering for sending a patch to revert the changes in
char-stdio.c ?
Thomas
next prev parent reply other threads:[~2018-06-07 11:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-06 17:15 [Qemu-devel] Stair step trace output since 12fb0ac05 BALATON Zoltan
2018-06-06 17:44 ` Philippe Mathieu-Daudé
2018-06-06 18:33 ` Peter Maydell
2018-06-07 11:14 ` Thomas Huth [this message]
2018-06-06 18:56 ` Markus Armbruster
2018-06-07 4:56 ` Thomas Huth
2018-06-07 5:17 ` Laurent Desnogues
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee8ff819-2344-bbaf-fa2e-e0c0a9d0f385@redhat.com \
--to=thuth@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).