From: Thomas Huth <thuth@redhat.com>
To: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org, Jason Wang <jasowang@redhat.com>,
Laurent Vivier <lvivier@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Yan Vugenfirer <yan@daynix.com>,
Yuri Benditovich <yuri.benditovich@daynix.com>
Subject: Re: [PATCH] tests/qtest/libqos/e1000e: Use e1000_regs.h
Date: Tue, 25 Oct 2022 16:54:40 +0200 [thread overview]
Message-ID: <ee90e31f-1036-1ce8-d1c1-174cc58cf0e0@redhat.com> (raw)
In-Reply-To: <20221013055245.28102-1-akihiko.odaki@daynix.com>
On 13/10/2022 07.52, Akihiko Odaki wrote:
> The register definitions in tests/qtest/libqos/e1000e.c had names
> different from hw/net/e1000_regs.h, which made it hard to understand
> what test codes corresponds to the implementation. Use
> hw/net/e1000_regs.h from tests/qtest/libqos/e1000e.c to remove
> these duplications.
>
> E1000E_CTRL_EXT_TXLSFLOW is removed from E1000E_CTRL_EXT settings
> because hw/net/e1000_regs.h does not have the definition and it is for
> TCP segmentation offload, which does not matter for the implemented
> tests.
>
> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
> ---
> hw/net/e1000_regs.h | 1 +
> tests/qtest/libqos/e1000e.c | 119 +++++++++++++-----------------------
> 2 files changed, 45 insertions(+), 75 deletions(-)
Acked-by: Thomas Huth <thuth@redhat.com>
I can take it through my testing-next tree:
https://gitlab.com/thuth/qemu/-/commits/testing-next
Thomas
next prev parent reply other threads:[~2022-10-25 14:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-13 5:52 [PATCH] tests/qtest/libqos/e1000e: Use e1000_regs.h Akihiko Odaki
2022-10-25 14:54 ` Thomas Huth [this message]
2022-11-07 7:45 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ee90e31f-1036-1ce8-d1c1-174cc58cf0e0@redhat.com \
--to=thuth@redhat.com \
--cc=akihiko.odaki@daynix.com \
--cc=jasowang@redhat.com \
--cc=lvivier@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yan@daynix.com \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).