From: Richard Henderson <richard.henderson@linaro.org>
To: Catherine Ho <catherine.hecx@gmail.com>,
"Emilio G. Cota" <cota@braap.org>,
Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, qemu-arm@nongnu.org
Subject: Re: [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be
Date: Mon, 11 Feb 2019 08:11:00 -0800 [thread overview]
Message-ID: <eeb0f275-b262-25db-337a-b6c78b29c124@linaro.org> (raw)
In-Reply-To: <1548985244-24523-1-git-send-email-catherine.hecx@gmail.com>
On 1/31/19 5:40 PM, Catherine Ho wrote:
> The lo,hi order is different from the comments. And in commit
> 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128"), it changes
> the original code logic. So just restore the old code logic before this
> commit:
> do_paired_cmpxchg64_be():
> cmpv = int128_make128(env->exclusive_high, env->exclusive_val);
> newv = int128_make128(new_hi, new_lo);
>
> Fixes: 1ec182c33379 ("target/arm: Convert to HAVE_CMPXCHG128")
>
> Signed-off-by: Catherine Ho <catherine.hecx@gmail.com>
> ---
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
next prev parent reply other threads:[~2019-02-11 16:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-01 1:40 [Qemu-devel] [RFC PATCH] target/arm: Fix int128_make128 lo, hi order in paired_cmpxchg64_be Catherine Ho
2019-02-11 16:11 ` Richard Henderson [this message]
2019-02-11 16:19 ` Peter Maydell
2019-02-11 16:49 ` Richard Henderson
2019-02-14 13:04 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eeb0f275-b262-25db-337a-b6c78b29c124@linaro.org \
--to=richard.henderson@linaro.org \
--cc=catherine.hecx@gmail.com \
--cc=cota@braap.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).