From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Greg Kurz <groug@kaod.org>
Subject: [PATCH v2 4/7] 9pfs: refactor 'name_idx' -> 'nwalked' in v9fs_walk()
Date: Sat, 12 Mar 2022 12:06:45 +0100 [thread overview]
Message-ID: <eebd764c82b49f50d83b5d64ecc28ac802fbea3b.1647083430.git.qemu_oss@crudebyte.com> (raw)
In-Reply-To: <cover.1647083430.git.qemu_oss@crudebyte.com>
The local variable 'name_idx' is used in two loops in function v9fs_walk().
Let the first loop use its own variable 'nwalked' instead, which we will
use in subsequent patch as the number of (requested) path components
successfully walked by background I/O thread.
Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
Reviewed-by: Greg Kurz <groug@kaod.org>
---
hw/9pfs/9p.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index a6d6b3f835..298f4e6548 100644
--- a/hw/9pfs/9p.c
+++ b/hw/9pfs/9p.c
@@ -1764,7 +1764,7 @@ static bool same_stat_id(const struct stat *a, const struct stat *b)
static void coroutine_fn v9fs_walk(void *opaque)
{
- int name_idx;
+ int name_idx, nwalked;
g_autofree V9fsQID *qids = NULL;
int i, err = 0;
V9fsPath dpath, path;
@@ -1842,17 +1842,17 @@ static void coroutine_fn v9fs_walk(void *opaque)
break;
}
stbuf = fidst;
- for (name_idx = 0; name_idx < nwnames; name_idx++) {
+ for (nwalked = 0; nwalked < nwnames; nwalked++) {
if (v9fs_request_cancelled(pdu)) {
err = -EINTR;
break;
}
if (!same_stat_id(&pdu->s->root_st, &stbuf) ||
- strcmp("..", wnames[name_idx].data))
+ strcmp("..", wnames[nwalked].data))
{
err = s->ops->name_to_path(&s->ctx, &dpath,
- wnames[name_idx].data,
- &pathes[name_idx]);
+ wnames[nwalked].data,
+ &pathes[nwalked]);
if (err < 0) {
err = -errno;
break;
@@ -1861,13 +1861,13 @@ static void coroutine_fn v9fs_walk(void *opaque)
err = -EINTR;
break;
}
- err = s->ops->lstat(&s->ctx, &pathes[name_idx], &stbuf);
+ err = s->ops->lstat(&s->ctx, &pathes[nwalked], &stbuf);
if (err < 0) {
err = -errno;
break;
}
- stbufs[name_idx] = stbuf;
- v9fs_path_copy(&dpath, &pathes[name_idx]);
+ stbufs[nwalked] = stbuf;
+ v9fs_path_copy(&dpath, &pathes[nwalked]);
}
}
});
--
2.30.2
next prev parent reply other threads:[~2022-03-12 12:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-12 11:10 [PATCH v2 0/7] 9pfs: fix 'Twalk' protocol violation Christian Schoenebeck
2022-03-12 11:06 ` [PATCH v2 1/7] tests/9pfs: walk to non-existent dir Christian Schoenebeck
2022-03-12 11:06 ` [PATCH v2 2/7] tests/9pfs: Twalk with nwname=0 Christian Schoenebeck
2022-03-12 11:06 ` [PATCH v2 3/7] tests/9pfs: compare QIDs in fs_walk_none() test Christian Schoenebeck
2022-03-12 11:06 ` Christian Schoenebeck [this message]
2022-03-12 11:06 ` [PATCH v2 5/7] 9pfs: fix 'Twalk' to only send error if no component walked Christian Schoenebeck
2022-03-13 8:47 ` Christian Schoenebeck
2022-03-12 11:06 ` [PATCH v2 6/7] tests/9pfs: guard recent 'Twalk' behaviour fix Christian Schoenebeck
2022-03-12 11:06 ` [PATCH v2 7/7] tests/9pfs: check fid being unaffected in fs_walk_2nd_nonexistent Christian Schoenebeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eebd764c82b49f50d83b5d64ecc28ac802fbea3b.1647083430.git.qemu_oss@crudebyte.com \
--to=qemu_oss@crudebyte.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).