From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Warner Losh <imp@bsdimp.com>, qemu-devel@nongnu.org
Cc: Kyle Evans <kevans@freebsd.org>
Subject: Re: [PATCH] bsd-user: Add missing break after do_bsd_preadv
Date: Mon, 21 Aug 2023 09:38:03 +0200 [thread overview]
Message-ID: <eee064fc-1c50-40d6-6bce-1613aaccd416@linaro.org> (raw)
In-Reply-To: <20230820045419.89691-1-imp@bsdimp.com>
On 20/8/23 06:54, Warner Losh wrote:
> Without it, we'd call preadv, then write with weird parameters, which is
> clearly not ideal...
>
> Signed-off-by: Warner Losh <imp@bsdimp.com>
> ---
> bsd-user/freebsd/os-syscall.c | 1 +
> 1 file changed, 1 insertion(+)
Ouch.
Fixes: 770d8abae7 ("bsd-user/bsd-file.h: Meat of the write system calls")
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
prev parent reply other threads:[~2023-08-21 7:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-20 4:54 [PATCH] bsd-user: Add missing break after do_bsd_preadv Warner Losh
2023-08-20 13:53 ` Richard Henderson
2023-08-21 7:38 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee064fc-1c50-40d6-6bce-1613aaccd416@linaro.org \
--to=philmd@linaro.org \
--cc=imp@bsdimp.com \
--cc=kevans@freebsd.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).