From: Akihiko Odaki <akihiko.odaki@daynix.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <lvivier@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [PATCH v2 1/4] Move dbus-display1 out of ui
Date: Sat, 16 Dec 2023 16:57:27 +0900 [thread overview]
Message-ID: <eee18cab-6e49-43bb-9e7f-bcd49dfd6a41@daynix.com> (raw)
In-Reply-To: <CAJ+F1C+pvRDmZpODinFuSzVYwPdrkar-ceo1aqWwAPtKbQztiw@mail.gmail.com>
On 2023/12/15 21:00, Marc-André Lureau wrote:
> Hi
>
> On Fri, Dec 15, 2023 at 3:29 PM Akihiko Odaki <akihiko.odaki@daynix.com> wrote:
>>
>> Despite its name, dbus-display1 does not only provide DBus interfaces
>> for the display but also for the audio.
>>
>> Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
>
> It can actually do a lot more, since you can arbitrarily redirect
> chardev devices.. USB, smartcard, QMP and what's not are possible.
>
> Yet, this is a -display module, so we should leave it under ui/ for now imho
I'm making this change specifically for audio. audio/dbusaudio.c has no
dependency on the display despite it's part of the dbus-display1 interface.
By the way, I noticed audio/dbusaudio.c includes ui/dbus.h for no reason
so I removed the inclusion in v3. It clarifies audio/dbus is independent
of ui/dbus.
Regards,
Akihiko Odaki
next prev parent reply other threads:[~2023-12-16 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 11:28 [PATCH v2 0/4] meson: Fixes for dbus modules Akihiko Odaki
2023-12-15 11:28 ` [PATCH v2 1/4] Move dbus-display1 out of ui Akihiko Odaki
2023-12-15 12:00 ` Marc-André Lureau
2023-12-16 7:57 ` Akihiko Odaki [this message]
2023-12-15 11:28 ` [PATCH v2 2/4] audio: Depend on dbus_display1_dep Akihiko Odaki
2023-12-15 12:04 ` Marc-André Lureau
2023-12-15 11:28 ` [PATCH v2 3/4] meson: Explicitly specify dbus-display1.h dependency Akihiko Odaki
2023-12-15 12:05 ` Marc-André Lureau
2023-12-15 11:28 ` [PATCH v2 4/4] tests/qtest: Depend on dbus_display1_dep Akihiko Odaki
2023-12-15 12:05 ` Marc-André Lureau
2024-02-14 8:09 ` [PATCH v2 0/4] meson: Fixes for dbus modules Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee18cab-6e49-43bb-9e7f-bcd49dfd6a41@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).