From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
qemu-devel@nongnu.org
Cc: mst@redhat.com, marcel.apfelbaum@gmail.com, imammedo@redhat.com,
jon.grimm@amd.com, santosh.Shukla@amd.com
Subject: Re: [PATCH] hw/i386/pc: Clean up pc_machine_initfn
Date: Fri, 9 Jun 2023 23:57:24 +0200 [thread overview]
Message-ID: <eee9de62-0a9d-c9b4-c749-29bd87343680@linaro.org> (raw)
In-Reply-To: <20230609164107.23404-1-suravee.suthikulpanit@amd.com>
On 9/6/23 18:41, Suravee Suthikulpanit wrote:
> To use the newly introduced PC machine class local variable.
>
> Suggedted-by: Igor Mammedov <imammedo@redhat.com>
"Suggested-by"
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
> hw/i386/pc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/pc.c b/hw/i386/pc.c
> index 33ffb03a32..f8d105e829 100644
> --- a/hw/i386/pc.c
> +++ b/hw/i386/pc.c
> @@ -1864,7 +1864,7 @@ static void pc_machine_initfn(Object *obj)
> pcms->smbios_entry_point_type = pcmc->default_smbios_ep_type;
>
> /* acpi build is enabled by default if machine supports it */
> - pcms->acpi_build_enabled = PC_MACHINE_GET_CLASS(pcms)->has_acpi_build;
> + pcms->acpi_build_enabled = pcmc->has_acpi_build;
> pcms->smbus_enabled = true;
> pcms->sata_enabled = true;
> pcms->i8042_enabled = true;
prev parent reply other threads:[~2023-06-09 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-09 16:41 [PATCH] hw/i386/pc: Clean up pc_machine_initfn Suravee Suthikulpanit
2023-06-09 21:57 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eee9de62-0a9d-c9b4-c749-29bd87343680@linaro.org \
--to=philmd@linaro.org \
--cc=imammedo@redhat.com \
--cc=jon.grimm@amd.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=santosh.Shukla@amd.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).