Re: [Qemu-devel] [PATCH 07/15] s390-bios: Decouple channel i/o logic from virtio

["Jason J. Herne" <jjherne@linux.ibm.com>]

On 1/31/19 9:38 AM, Farhan Ali wrote:
> 
> 
> On 01/29/2019 08:29 AM, Jason J. Herne wrote:
>> Create a separate library for channel i/o related code. This decouples
>> channel i/o operations from virtio and allows us to make use of them for
>> the real dasd boot path.
>>
>> Signed-off-by: Jason J. Herne <jjherne@linux.ibm.com>
>> ---
>>   pc-bios/s390-ccw/Makefile        |  2 +-
>>   pc-bios/s390-ccw/cio.c           | 41 ++++++++++++++++++++++++++++++++++++++++
>>   pc-bios/s390-ccw/cio.h           |  3 +++
>>   pc-bios/s390-ccw/main.c          |  1 +
>>   pc-bios/s390-ccw/netboot.mak     |  2 +-
>>   pc-bios/s390-ccw/netmain.c       |  1 +
>>   pc-bios/s390-ccw/s390-ccw.h      |  1 -
>>   pc-bios/s390-ccw/virtio-blkdev.c |  1 +
>>   pc-bios/s390-ccw/virtio.c        | 27 ++------------------------
>>   9 files changed, 51 insertions(+), 28 deletions(-)
>>   create mode 100644 pc-bios/s390-ccw/cio.c
>>
>> diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile
>> index 1eb316b..12ad9c1 100644
>> --- a/pc-bios/s390-ccw/Makefile
>> +++ b/pc-bios/s390-ccw/Makefile
>> @@ -10,7 +10,7 @@ $(call set-vpath, $(SRC_PATH)/pc-bios/s390-ccw)
>>   .PHONY : all clean build-all
>>   OBJECTS = start.o main.o bootmap.o jump2ipl.o sclp.o menu.o \
>> -      virtio.o virtio-scsi.o virtio-blkdev.o libc.o
>> +      virtio.o virtio-scsi.o virtio-blkdev.o libc.o cio.o
>>   QEMU_CFLAGS := $(filter -W%, $(QEMU_CFLAGS))
>>   QEMU_CFLAGS += -ffreestanding -fno-delete-null-pointer-checks -msoft-float
>> diff --git a/pc-bios/s390-ccw/cio.c b/pc-bios/s390-ccw/cio.c
>> new file mode 100644
>> index 0000000..095f79b
>> --- /dev/null
>> +++ b/pc-bios/s390-ccw/cio.c
>> @@ -0,0 +1,41 @@
>> +/*
>> + * S390 Channel I/O
>> + *
>> + * Copyright (c) 2018 Jason J. Herne <jjherne@us.ibm.com>
>> + *
>> + * This work is licensed under the terms of the GNU GPL, version 2 or (at
>> + * your option) any later version. See the COPYING file in the top-level
>> + * directory.
>> + */
>> +
> 
> shouldn't the year be 2019 now? :)

I suppose. I did write it in 2018 :-P I'll update it.

-- 
-- Jason J. Herne (jjherne@linux.ibm.com)