From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>, qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"LIU Zhiwei" <zhiwei_liu@linux.alibaba.com>,
"Nicholas Piggin" <npiggin@gmail.com>,
qemu-ppc@nongnu.org, "David Gibson" <david@gibson.dropbear.id.au>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
"Thomas Huth" <thuth@redhat.com>,
"Frédéric Barrat" <fbarrat@linux.ibm.com>
Subject: Re: [PATCH v3 0/7] hw/ppc: SysBus simplifications
Date: Thu, 19 Oct 2023 17:41:33 +0200 [thread overview]
Message-ID: <ef1468f4-b21e-460b-b735-a43eca7f3b9f@kaod.org> (raw)
In-Reply-To: <20231019131647.19690-1-philmd@linaro.org>
On 10/19/23 15:16, Philippe Mathieu-Daudé wrote:
> Hi,
>
> There is no point in exposing an internal MMIO region via
> SysBus and directly mapping it in the very same device.
>
> This series replaces a sequence of:
> - sysbus_init_mmio()
> - sysbus_mmio_map()
> by a single call to memory_region_add_subregion().
Nice cleanup !
Reviewed-by: Cédric Le Goater <clg@kaod.org>
Thanks,
C.
> Since v2:
> - Mention coccinelle script in patch descriptions
>
> Since v1:
> - New "Realize SPAPR_VIO_BRIDGE device before accessing it" patch
> - Added R-b tags
>
> Philippe Mathieu-Daudé (7):
> hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it
> hw/ppc/pnv_xscom: Rename pnv_xscom_realize(Error **) ->
> pnv_xscom_init()
> hw/ppc/pnv_xscom: Move sysbus_mmio_map() call within pnv_xscom_init()
> hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region
> hw/ppc/pnv: Do not use SysBus API to map local MMIO region
> hw/intc/spapr_xive: Move sysbus_init_mmio() calls around
> hw/intc/spapr_xive: Do not use SysBus API to map local MMIO region
>
> include/hw/ppc/pnv_xscom.h | 2 +-
> hw/intc/spapr_xive.c | 12 ++++++------
> hw/ppc/pnv.c | 26 +++++---------------------
> hw/ppc/pnv_xscom.c | 5 ++---
> hw/ppc/spapr_vio.c | 3 ++-
> 5 files changed, 16 insertions(+), 32 deletions(-)
>
next prev parent reply other threads:[~2023-10-19 15:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-19 13:16 [PATCH v3 0/7] hw/ppc: SysBus simplifications Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 1/7] hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it Philippe Mathieu-Daudé
2023-10-19 15:47 ` Thomas Huth
2023-10-19 13:16 ` [PATCH v3 2/7] hw/ppc/pnv_xscom: Rename pnv_xscom_realize(Error **) -> pnv_xscom_init() Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 3/7] hw/ppc/pnv_xscom: Move sysbus_mmio_map() call within pnv_xscom_init() Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 4/7] hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 5/7] hw/ppc/pnv: " Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 6/7] hw/intc/spapr_xive: Move sysbus_init_mmio() calls around Philippe Mathieu-Daudé
2023-10-19 13:16 ` [PATCH v3 7/7] hw/intc/spapr_xive: Do not use SysBus API to map local MMIO region Philippe Mathieu-Daudé
2023-10-19 15:41 ` Cédric Le Goater [this message]
2023-10-19 21:38 ` [PATCH v3 0/7] hw/ppc: SysBus simplifications Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef1468f4-b21e-460b-b735-a43eca7f3b9f@kaod.org \
--to=clg@kaod.org \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=fbarrat@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=npiggin@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
--cc=zhiwei_liu@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).