From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10613CDB465 for ; Thu, 19 Oct 2023 15:44:09 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qtV9i-0003oo-LN; Thu, 19 Oct 2023 11:41:50 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtV9g-0003Y0-D8; Thu, 19 Oct 2023 11:41:48 -0400 Received: from gandalf.ozlabs.org ([150.107.74.76]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qtV9e-0002nu-8C; Thu, 19 Oct 2023 11:41:48 -0400 Received: from gandalf.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by gandalf.ozlabs.org (Postfix) with ESMTP id 4SBBlm4n9Fz4xfD; Fri, 20 Oct 2023 02:41:40 +1100 (AEDT) Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 4SBBlj160Cz4xdy; Fri, 20 Oct 2023 02:41:36 +1100 (AEDT) Message-ID: Date: Thu, 19 Oct 2023 17:41:33 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/7] hw/ppc: SysBus simplifications Content-Language: en-US To: =?UTF-8?Q?Philippe_Mathieu-Daud=C3=A9?= , qemu-devel@nongnu.org Cc: Richard Henderson , LIU Zhiwei , Nicholas Piggin , qemu-ppc@nongnu.org, David Gibson , Daniel Henrique Barboza , Harsh Prateek Bora , Thomas Huth , =?UTF-8?B?RnLDqWTDqXJpYyBCYXJyYXQ=?= References: <20231019131647.19690-1-philmd@linaro.org> From: =?UTF-8?Q?C=C3=A9dric_Le_Goater?= In-Reply-To: <20231019131647.19690-1-philmd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=150.107.74.76; envelope-from=SRS0=PA0m=GB=kaod.org=clg@ozlabs.org; helo=gandalf.ozlabs.org X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On 10/19/23 15:16, Philippe Mathieu-Daudé wrote: > Hi, > > There is no point in exposing an internal MMIO region via > SysBus and directly mapping it in the very same device. > > This series replaces a sequence of: > - sysbus_init_mmio() > - sysbus_mmio_map() > by a single call to memory_region_add_subregion(). Nice cleanup ! Reviewed-by: Cédric Le Goater Thanks, C. > Since v2: > - Mention coccinelle script in patch descriptions > > Since v1: > - New "Realize SPAPR_VIO_BRIDGE device before accessing it" patch > - Added R-b tags > > Philippe Mathieu-Daudé (7): > hw/ppc/spapr_vio: Realize SPAPR_VIO_BRIDGE device before accessing it > hw/ppc/pnv_xscom: Rename pnv_xscom_realize(Error **) -> > pnv_xscom_init() > hw/ppc/pnv_xscom: Move sysbus_mmio_map() call within pnv_xscom_init() > hw/ppc/pnv_xscom: Do not use SysBus API to map local MMIO region > hw/ppc/pnv: Do not use SysBus API to map local MMIO region > hw/intc/spapr_xive: Move sysbus_init_mmio() calls around > hw/intc/spapr_xive: Do not use SysBus API to map local MMIO region > > include/hw/ppc/pnv_xscom.h | 2 +- > hw/intc/spapr_xive.c | 12 ++++++------ > hw/ppc/pnv.c | 26 +++++--------------------- > hw/ppc/pnv_xscom.c | 5 ++--- > hw/ppc/spapr_vio.c | 3 ++- > 5 files changed, 16 insertions(+), 32 deletions(-) >