Re: [PATCH-for-11.1 00/10] monitor: Remove need of per-target handlers

[Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>]

On 3/20/2026 1:08 PM, Philippe Mathieu-Daudé wrote:
> Convert target_monitor_defs() and target_monitor_defs()
> to CPUClass fields, adapting the 4 targets using these
> legacy code.

So I saw in patch 3 this explanation:


+ * @legacy_monitor_defs: Array of MonitorDef entries. This field is legacy,
+ *                       use @gdb_core_xml_file to dump registers instead.


I can move target/riscv to gdb_core_xml_file and get out of your way in
deprecating this API so you have one less target to worry about.  I'll
see what other targets are doing w.r.t gdb_core_xml_file.

In fact, depending on the amount of pain involved, we should just convert
all targets and remove the legacy API completely.  Or maybe I'm not fully
appreciating the scope of what you're doing here: will we impact users if
we just convert all users to gdb_core_xml_file?  Do we have HMP/QMP commands
that will be impacted?  Because if not we should consider just convert everything
and be done with it - there's not 'turn legacy for a couple of releases
before removing it' for internals APIs.


Thanks,
Daniel

> 
> Philippe Mathieu-Daudé (10):
>    monitor: Extract completion declarations to 'monitor/hmp-completion.h'
>    monitor: Forward-declare the MonitorDef type
>    cpus: Introduce CPUClass::legacy_monitor_defs hook
>    target/i386: Replace legacy target_monitor_defs -> legacy_monitor_defs
>    target/m68k: Replace legacy target_monitor_defs -> legacy_monitor_defs
>    target/sparc: Replace legacy target_monitor_defs ->
>      legacy_monitor_defs
>    monitor: Remove target_monitor_defs()
>    cpus: Introduce CPUClass::legacy_monitor_get_register() hook
>    target/riscv: Register target_get_monitor_def in CPUClass
>    monitor: Remove target_get_monitor_def()
> 
>   MAINTAINERS                      |  1 +
>   include/hw/core/cpu.h            |  8 +++++++
>   include/monitor/hmp-completion.h | 40 ++++++++++++++++++++++++++++++++
>   include/monitor/hmp.h            | 28 ++--------------------
>   include/qemu/typedefs.h          |  1 +
>   target/i386/cpu.h                |  2 ++
>   target/m68k/cpu.h                |  2 ++
>   target/riscv/internals.h         |  3 +++
>   target/sparc/cpu.h               |  2 ++
>   chardev/char-hmp-cmds.c          |  1 +
>   migration/migration-hmp-cmds.c   |  1 +
>   monitor/hmp-target.c             |  1 +
>   monitor/hmp.c                    |  8 +++++--
>   net/net-hmp-cmds.c               |  1 +
>   qom/qom-hmp-cmds.c               |  1 +
>   stubs/target-get-monitor-def.c   | 29 -----------------------
>   stubs/target-monitor-defs.c      |  7 ------
>   system/qdev-monitor.c            |  1 +
>   system/runstate-hmp-cmds.c       |  1 +
>   target/i386/cpu.c                |  1 +
>   target/i386/monitor.c            |  7 ++----
>   target/m68k/cpu.c                |  1 +
>   target/m68k/monitor.c            |  5 +---
>   target/riscv/cpu.c               |  1 +
>   target/riscv/monitor.c           |  4 +++-
>   target/sparc/cpu.c               |  3 +++
>   target/sparc/monitor.c           |  9 +++----
>   trace/trace-hmp-cmds.c           |  1 +
>   ui/ui-hmp-cmds.c                 |  1 +
>   stubs/meson.build                |  2 --
>   30 files changed, 91 insertions(+), 82 deletions(-)
>   create mode 100644 include/monitor/hmp-completion.h
>   delete mode 100644 stubs/target-get-monitor-def.c
>   delete mode 100644 stubs/target-monitor-defs.c
>