From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59855) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bv2ta-0004IH-40 for qemu-devel@nongnu.org; Fri, 14 Oct 2016 09:51:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bv2tT-0003YK-VV for qemu-devel@nongnu.org; Fri, 14 Oct 2016 09:51:33 -0400 References: <1476435295-21885-1-git-send-email-eric.auger@redhat.com> <1476435295-21885-3-git-send-email-eric.auger@redhat.com> <20161014144129.7826bfc8@nial.brq.redhat.com> From: Auger Eric Message-ID: Date: Fri, 14 Oct 2016 15:51:12 +0200 MIME-Version: 1.0 In-Reply-To: <20161014144129.7826bfc8@nial.brq.redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 2/2] ARM: Virt: ACPI: Build an IORT table with RC and ITS nodes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: peter.maydell@linaro.org, drjones@redhat.com, tn@semihalf.com, qemu-devel@nongnu.org, qemu-arm@nongnu.org, shannon.zhao@linaro.org, prem.mallappa@broadcom.com, christoffer.dall@linaro.org, eric.auger.pro@gmail.com Hi Igor, Shannon On 14/10/2016 14:41, Igor Mammedov wrote: > On Fri, 14 Oct 2016 10:54:55 +0200 > Eric Auger wrote: > >> From: Prem Mallappa >> >> This patch builds an IORT table that features a root complex node and >> an ITS node. This complements the ITS description in the ACPI MADT >> table and allows vhost-net on ACPI guest. >> >> Signed-off-by: Prem Mallappa >> Signed-off-by: Eric Auger >> >> --- >> >> v1 -> v2: >> - its_class_name() || !guest_info->no_its now wraps acpi_add_table >> and build_iort >> - add cpu_to_le* >> - CCA = CPM = DACS = 1 >> - cleanup according to Drew's comments >> - remove comments listing tables and spec revisions >> --- >> hw/arm/virt-acpi-build.c | 73 ++++++++++++++++++++++++++++++++++++++++-------- >> 1 file changed, 62 insertions(+), 11 deletions(-) >> >> diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c >> index fa0655a..5fc0fd7 100644 >> --- a/hw/arm/virt-acpi-build.c >> +++ b/hw/arm/virt-acpi-build.c > [...] > >> +static void >> build_spcr(GArray *table_data, BIOSLinker *linker, VirtGuestInfo *guest_info) >> { >> AcpiSerialPortConsoleRedirection *spcr; >> @@ -667,17 +724,6 @@ void virt_acpi_build(VirtGuestInfo *guest_info, AcpiBuildTables *tables) >> ACPI_BUILD_TABLE_FILE, tables_blob, >> 64, false /* high memory */); >> >> - /* >> - * The ACPI v5.1 tables for Hardware-reduced ACPI platform are: >> - * RSDP >> - * RSDT >> - * FADT >> - * GTDT >> - * MADT >> - * MCFG >> - * DSDT >> - */ > deleting unrelated hunk? This follows one Drew's comment stating this was not really useful to continue maintaining it. If Shannon agrees I can submit a separate patch then to remove it. Waiting for Shannon's answer ... Thanks Eric > >> - >> /* DSDT is pointed to by FADT */ >> dsdt = tables_blob->len; >> build_dsdt(tables_blob, tables->linker, guest_info); >> @@ -703,6 +749,11 @@ void virt_acpi_build(VirtGuestInfo *guest_info, AcpiBuildTables *tables) >> build_srat(tables_blob, tables->linker, guest_info); >> } >> >> + if (its_class_name() && !guest_info->no_its) { >> + acpi_add_table(table_offsets, tables_blob); >> + build_iort(tables_blob, tables->linker, guest_info); >> + } >> + >> /* RSDT is pointed to by RSDP */ >> rsdt = tables_blob->len; >> build_rsdt(tables_blob, tables->linker, table_offsets, NULL, NULL); > >