From: Scott Tsai <scottt.tw@gmail.com>
To: Avi Kivity <avi@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer
Date: Tue, 10 Nov 2009 23:14:47 +0800 [thread overview]
Message-ID: <ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com> (raw)
In-Reply-To: <4AF97D3B.8080601@redhat.com>
>> + s->temperature++;
>>
> You're going to overheat very quickly.
> Apart from making the driver work, is this actually useful?
I wanted the temperature to change with time to give a sense of
"something is happening" ^_^
The main user I had in mind was someone new to USB and Linux driver development
following gregkh's driver tutorial:
http://www.kroah.com/linux/talks/ols_2005_driver_tutorial/
My thinking was that if the temperature never changes, all the USB
packets generated in the 'read_int_callback"
part of the driver would seem like a waste of effort.
next prev parent reply other threads:[~2009-11-10 15:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-10 9:37 [Qemu-devel] [PATCH V2 0/3] usb-gotemp: USB thermometer emulation Scott Tsai
2009-11-10 9:37 ` [Qemu-devel] [PATCH V2 1/3] usb: move HID request defines to hw/usb.h Scott Tsai
2009-11-10 9:37 ` [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer Scott Tsai
2009-11-10 9:37 ` [Qemu-devel] [PATCH V2 3/3] Documentation: -usbdevice thermometer option Scott Tsai
2009-11-10 14:48 ` [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer Avi Kivity
2009-11-10 15:14 ` Scott Tsai [this message]
2009-11-10 15:33 ` Alexander Graf
2009-11-10 15:55 ` Scott Tsai
2009-11-10 17:06 ` Luiz Capitulino
2009-11-10 17:52 ` Scott Tsai
2009-11-10 20:52 ` Luiz Capitulino
2009-11-11 0:06 ` [Qemu-devel] [PATCH V3 2/3] usb-gotemp: reworked to add monitor commands Scott Tsai
2009-11-11 0:09 ` [Qemu-devel] [PATCH V2 2/3] usb-gotemp: new module emulating a USB thermometer Anthony Liguori
2009-11-11 0:15 ` Alexander Graf
2009-11-11 0:57 ` Greg KH
2009-11-11 1:05 ` Alexander Graf
2009-11-11 1:06 ` Scott Tsai
2009-12-04 5:28 ` Greg KH
2009-11-11 2:10 ` Scott Tsai
2009-11-10 16:50 ` Avi Kivity
2009-11-10 15:39 ` [Qemu-devel] " Juan Quintela
2009-11-10 15:56 ` Scott Tsai
-- strict thread matches above, loose matches on Subject: below --
2009-11-10 15:22 [Qemu-devel] " Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ef2f888d0911100714k351de5b8hea3a2b48935bde25@mail.gmail.com \
--to=scottt.tw@gmail.com \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).